Skip to content

Implement the sbc encoder and decoder based on Android Bluetooth SBC #88865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement the sbc encoder and decoder based on Android Bluetooth SBC #88865

wants to merge 2 commits into from
+383 −0

Conversation

MarkWangChinese
Copy link
Collaborator

  • It is based on Android Bluetooth SBC.
  • The Android Bluetooth SBC is being proposed as an external library in submodule repo (libsbc).

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 21, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
libsbc 🆕 N/A (Added) zephyrproject-rtos/libsbc@8e1beda (main) N/A

⛔ DNM label due to: 1 added project

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-libsbc DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Apr 21, 2025
@MarkWangChinese MarkWangChinese force-pushed the feature/impl_sbc_codec branch 2 times, most recently from 85f9924 to 4a7d78d Compare April 25, 2025 08:36
@nashif nashif added the area: Bluetooth Classic Bluetooth Classic (BR/EDR) label Apr 26, 2025
@nashif nashif requested a review from jhedberg April 26, 2025 14:06
jhedberg
jhedberg requested changes Apr 26, 2025
View reviewed changes
Copy link
Member

@jhedberg jhedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on function return values

@MarkWangChinese MarkWangChinese force-pushed the feature/impl_sbc_codec branch from 4a7d78d to d79fa33 Compare April 30, 2025 01:42
@github-actions GitHub Actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jun 30, 2025
@MarkWangChinese
Copy link
Collaborator Author

Hi @dleach02 @nashif @carlescufi @MaureenHelm @stephanosio Could you please help to review? The only CI error is caused by the manifest change.

@dleach02 dleach02 closed this Jul 14, 2025
@dleach02
Copy link
Member

close/reopen to clear CI

@dleach02 dleach02 reopened this Jul 14, 2025
@MarkWangChinese
libsbc: sbc: implement SBC codec
ca95526 
Use the Android Bluetooth SBC encoder and decoder.
The Android Bluetooth SBC is put as external library (libsbc).
sbc.c/sbc.h implement the interface that is compliant with
Zephyr style and can be used by Zephyr's other modules (
like A2DP).

Signed-off-by: Mark Wang <yichang.wang@nxp.com>
@MarkWangChinese
west: MAINTAINERS: add libsbc
9a1f2f5 
add libsbc to west.yml and add libsbc to MAINTAINERS.yml

Signed-off-by: Mark Wang <yichang.wang@nxp.com>
@MarkWangChinese MarkWangChinese force-pushed the feature/impl_sbc_codec branch from d79fa33 to 9a1f2f5 Compare July 15, 2025 02:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhedberg jhedberg jhedberg approved these changes

@dleach02 dleach02 dleach02 approved these changes

@nashif nashif Awaiting requested review from nashif

@carlescufi carlescufi Awaiting requested review from carlescufi

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@stephanosio stephanosio Awaiting requested review from stephanosio

Assignees

@nashif nashif

@MaureenHelm MaureenHelm

Labels
area: Bluetooth Classic Bluetooth Classic (BR/EDR) area: Process DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-libsbc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MarkWangChinese @dleach02 @jhedberg @nashif @MaureenHelm