posix: options: add custom Zephyr POSIX subprofile #88547

cfriedt · 2025-04-12T12:20:15Z

eventfd: bring config to top-level of posix dir, since it is not posix
posix: separate option groups into c library ext and system interfaces
posix: profiles: add custom Zephyr POSIX subprofile
posix: profiles: make POSIX_AEP_CHOICE_ZEPHYR the default
posix: options: add keep-sorted-start and -stop

Should only be merged after

Note

The sources used when CONFIG_POSIX_C_LANG_SUPPORT_R=y and CONFIG_POSIX_C_LIB_EXT=y can still be
overridden with CONFIG_TC_PROVIDES_POSIX_C_LANG_SUPPORT_R=y an CONFIG_TC_PROVIDES_POSIX_C_LIB_EXT=y (which must be used with select <option> in Kconfig), as they are primarily meant for toolchain maintainers.

A comparison when building samples/hello_world for native_sim.

Before:

wc -l build-main/zephyr/.config
   1295 build-main/zephyr/.config

After:

wc -l build-branch/zephyr/.config
   1220 build-branch/zephyr/.config

diff -Nua build-{main,branch}/zephyr/.config

--- build-main/zephyr/.config   2025-05-24 11:33:53.697011215 -0400
+++ build-branch/zephyr/.config 2025-05-24 11:34:27.140913656 -0400
@@ -900,98 +900,23 @@
 #
 # POSIX API Support
 #
-
-#
-# POSIX Options
-#
 # CONFIG_POSIX_API is not set
-CONFIG_POSIX_AEP_CHOICE_NONE=y
-# CONFIG_POSIX_AEP_CHOICE_BASE is not set
-# CONFIG_POSIX_AEP_CHOICE_PSE51 is not set
-# CONFIG_POSIX_AEP_CHOICE_PSE52 is not set
-# CONFIG_POSIX_AEP_CHOICE_PSE53 is not set
-# CONFIG_POSIX_ASYNCHRONOUS_IO is not set
-# CONFIG_POSIX_BARRIERS is not set
-# CONFIG_POSIX_C_LANG_SUPPORT_R is not set
-# CONFIG_POSIX_C_LIB_EXT is not set
-
-#
-# POSIX device I/O
-#
-# CONFIG_POSIX_DEVICE_IO is not set
-CONFIG_POSIX_OPEN_MAX=4
-# end of POSIX device I/O
-
-# CONFIG_POSIX_FD_MGMT is not set
-# CONFIG_POSIX_FILE_SYSTEM_R is not set
-# CONFIG_POSIX_FILE_SYSTEM is not set
-
-#
-# POSIX memory
-#
-CONFIG_POSIX_PAGE_SIZE=0x40
-# CONFIG_POSIX_SHARED_MEMORY_OBJECTS is not set
-# CONFIG_POSIX_MAPPED_FILES is not set
-# CONFIG_POSIX_MEMORY_PROTECTION is not set
-# end of POSIX memory
-
-# CONFIG_POSIX_MESSAGE_PASSING is not set
-# CONFIG_POSIX_SINGLE_PROCESS is not set
-# CONFIG_POSIX_MULTI_PROCESS is not set
-# CONFIG_POSIX_THREADS is not set
-# CONFIG_POSIX_READER_WRITER_LOCKS is not set
-
-#
-# POSIX scheduler options
-#
-# CONFIG_POSIX_PRIORITY_SCHEDULING is not set
-# end of POSIX scheduler options
-
-# CONFIG_POSIX_SEMAPHORES is not set
-
-#
-# POSIX signals
-#
-# CONFIG_POSIX_REALTIME_SIGNALS is not set
-# CONFIG_POSIX_SIGNALS is not set
-# end of POSIX signals
-
-# CONFIG_POSIX_SPIN_LOCKS is not set
-
-#
-# POSIX synchronized I/O
-#
-# CONFIG_POSIX_FSYNC is not set
-# CONFIG_POSIX_SYNCHRONIZED_IO is not set
-# end of POSIX synchronized I/O
-
-# CONFIG_POSIX_TIMERS is not set
-
-#
-# X/Open system interfaces
-#
-# CONFIG_XSI_REALTIME is not set
-# CONFIG_XSI_SINGLE_PROCESS is not set
-# CONFIG_XOPEN_STREAMS is not set
-# CONFIG_XSI_SYSTEM_LOGGING is not set
-# CONFIG_XSI_THREADS_EXT is not set
-# end of X/Open system interfaces
-
-#
-# Miscellaneous POSIX-related options
-#
-# CONFIG_EVENTFD is not set
-# end of Miscellaneous POSIX-related options
-
+# CONFIG_POSIX_AEP_CHOICE_NONE is not set
+CONFIG_POSIX_AEP_CHOICE_ZEPHYR=y
 CONFIG_TC_PROVIDES_POSIX_C_LANG_SUPPORT_R=y
-# end of POSIX Options
 
 #
-# POSIX Shell Utilities
+# POSIX C Library Extensions
 #
-# end of POSIX Shell Utilities
+CONFIG_POSIX_C_LANG_SUPPORT_R=y
+CONFIG_POSIX_C_LIB_EXT=y
+# CONFIG_GETOPT_LONG is not set
+# end of POSIX C Library Extensions
+
+# CONFIG_POSIX_SYSTEM_INTERFACES is not set
 # end of POSIX API Support
 
+# CONFIG_EVENTFD is not set
 # CONFIG_OPENAMP_RSC_TABLE is not set
 # CONFIG_SMF is not set
 CONFIG_LIBGCC_RTLIB=y

cfriedt · 2025-04-12T12:42:04Z

Probably one or two follow-up PRs can be made to ensure that the POSIX_C_LIB_EXT Option Group is complete. I think there are some string manipulation functions missing (not ISO C).

Currently, all of the implementation of POSIX_C_LANG_SUPPORT_R is done in libc/common, which ... doesn't matter too much, but that could be corrected later if necessary.

cfriedt · 2025-04-14T13:41:59Z

Shell utilities should probably also be gated by the new Kconfig.

lib/posix/Kconfig

jukkar

Thanks Chris, this helps to understand what is going on with the POSIX options.

jukkar · 2025-04-15T09:47:34Z

lib/posix/Kconfig.profile

+
+	  These functions are divided into two standalone Option Groups that may be enabled
+	  independently of the remainder of the POSIX API implementation; namely POSIX_C_LIB_EXT and
+	  POSIX_C_LANG_SUPPORT_R. If not referenced by the Zephyr kernel or application, There are no


Suggested change

POSIX_C_LANG_SUPPORT_R. If not referenced by the Zephyr kernel or application, There are no

POSIX_C_LANG_SUPPORT_R. If not referenced by the Zephyr kernel or application, there are no

cfriedt · 2025-05-14T10:10:46Z

I'll give this a rebase shorty

Separate the POSIX implementation into two categories: - Extensions to ISO C - System Interfaces The first category include standalone functions that generally do not require OS support or depend on any other features within the POSIX specification. The Option Groups that comprise this category include - POSIX_C_LIB_EXT: e.g. strnlen(), fnmatch() - POSIX_C_LANG_SUPPORT_R: e.g. gmtime_r(), strtok_r() The second category includes the majority of other POSIX Option Groups that do require OS support. The latter group may also be categorized generally as being NATIVE_LIBC_INCOMPATIBLE, although that might eventually become more granular. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>

Add a custom Zephyr POSIX subprofile specifically for enabling the default features that Zephyr requires as per the coding guidelines. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>

Default POSIX_AEP_CHOICE to POSIX_AEP_CHOICE_ZEPHYR Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>

Add zephyr-keep-sorted-start and zephyr-keep-sorted-stop comments. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>

Indentation was fixed

cfriedt · 2025-05-25T03:35:35Z

Removed commits that should be part of a different PR.

sonarqubecloud · 2025-05-25T03:55:28Z

Please retry analysis of this Pull-Request directly on SonarQube Cloud

cfriedt force-pushed the add-zephyr-posix-aep-choice branch from 0d193e5 to f68b0fb Compare April 12, 2025 12:31

cfriedt requested review from nashif, JordanYates and ycsin April 12, 2025 12:37

cfriedt added the area: POSIX POSIX API Library label Apr 12, 2025

cfriedt assigned ycsin Apr 12, 2025

cfriedt force-pushed the add-zephyr-posix-aep-choice branch 4 times, most recently from e891f53 to 10c619d Compare April 12, 2025 15:29

JordanYates previously requested changes Apr 14, 2025

View reviewed changes

lib/posix/Kconfig Show resolved Hide resolved

jukkar reviewed Apr 15, 2025

View reviewed changes

cfriedt force-pushed the add-zephyr-posix-aep-choice branch 5 times, most recently from db9804b to 2ca347b Compare April 25, 2025 03:31

cfriedt force-pushed the add-zephyr-posix-aep-choice branch 2 times, most recently from aeb78be to 7ac5797 Compare April 29, 2025 01:15

cfriedt mentioned this pull request May 3, 2025

posix: implement xsi_single_process and posix_clock_selection #89068

Merged

cfriedt force-pushed the add-zephyr-posix-aep-choice branch 3 times, most recently from 04b8fa8 to df478b2 Compare May 18, 2025 03:52

cfriedt added 4 commits May 24, 2025 11:30

posix: profiles: add custom Zephyr POSIX subprofile

0893e24

Add a custom Zephyr POSIX subprofile specifically for enabling the default features that Zephyr requires as per the coding guidelines. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>

posix: profiles: make POSIX_AEP_CHOICE_ZEPHYR the default

1b155a8

Default POSIX_AEP_CHOICE to POSIX_AEP_CHOICE_ZEPHYR Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>

posix: options: add keep-sorted-start and -stop

b1e87fc

Add zephyr-keep-sorted-start and zephyr-keep-sorted-stop comments. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>

cfriedt force-pushed the add-zephyr-posix-aep-choice branch from a73425b to b1e87fc Compare May 24, 2025 15:32

cfriedt requested review from jukkar and JordanYates May 24, 2025 15:45

cfriedt marked this pull request as ready for review May 24, 2025 15:45

github-actions bot added area: C Library C Standard Library area: Base OS Base OS Library (lib/os) area: Samples Samples area: Utilities Release Notes To be mentioned in the release notes area: LWM2M area: Networking area: Process labels May 24, 2025

github-actions bot requested review from aescolar, andyross, dcpleung, kartben, keith-packard, pdgendt, peter-mitsis, rlubos, ssharks and stephanosio May 24, 2025 15:47

cfriedt force-pushed the add-zephyr-posix-aep-choice branch from 02a72f0 to b1e87fc Compare May 25, 2025 03:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

posix: options: add custom Zephyr POSIX subprofile #88547

posix: options: add custom Zephyr POSIX subprofile #88547

Uh oh!

cfriedt commented Apr 12, 2025 •

edited

Loading

Uh oh!

cfriedt commented Apr 12, 2025

Uh oh!

cfriedt commented Apr 14, 2025

Uh oh!

Uh oh!

jukkar left a comment

Uh oh!

jukkar Apr 15, 2025

Uh oh!

cfriedt Apr 18, 2025

Uh oh!

cfriedt commented May 14, 2025

Uh oh!

cfriedt commented May 25, 2025

Uh oh!

sonarqubecloud bot commented May 25, 2025

Uh oh!

Uh oh!

	POSIX_C_LANG_SUPPORT_R. If not referenced by the Zephyr kernel or application, There are no
	POSIX_C_LANG_SUPPORT_R. If not referenced by the Zephyr kernel or application, there are no

posix: options: add custom Zephyr POSIX subprofile #88547

Are you sure you want to change the base?

posix: options: add custom Zephyr POSIX subprofile #88547

Uh oh!

Conversation

cfriedt commented Apr 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cfriedt commented Apr 12, 2025

Uh oh!

cfriedt commented Apr 14, 2025

Uh oh!

Uh oh!

jukkar left a comment

Choose a reason for hiding this comment

Uh oh!

jukkar Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

cfriedt Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

cfriedt commented May 14, 2025

Uh oh!

cfriedt commented May 25, 2025

Uh oh!

sonarqubecloud bot commented May 25, 2025

Uh oh!

Uh oh!

cfriedt commented Apr 12, 2025 •

edited

Loading