fuel_gauge: composite: more flexible data sourcing and channel querying #88397
+145
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Fuel Gauge
area: Devicetree
area: Sensors
github-actions
bot
requested review from
aaronemassey,
asemjonovs,
avisconti,
decsny,
galak,
jeppenodgaard,
MaureenHelm,
rruuaanng,
teburd,
tristan-google,
ubieda and
yperess
JordanYates
force-pushed
the
250410_fuel_gauge_comp_tick
branch
from
20654a5 to
df92728
Compare
JordanYates
force-pushed
the
250410_fuel_gauge_comp_tick
branch
from
df92728 to
f04e454
Compare
|
CI failure is unrelated: #88398 |
JordanYates
force-pushed
the
250410_fuel_gauge_comp_tick
branch
from
f04e454 to
a43f783
Compare
To ensure that data is consistent across multiple sequential calls to `fuel_gauge_get_prop`, sensor_fetch is only called if a certain time period has passed since the previous sampling. This emulates the tick-based sampling of most dedicated fuel-gauge devices. Signed-off-by: Jordan Yates <jordan@embeint.com> tick
Instead of explicitly specifying the source for the voltage and current channels, specify primary and secondary data sources. If the requested sensor channel does not exist on the primary source, the secondary source will be tried. Signed-off-by: Jordan Yates <jordan@embeint.com>
Choose whether the data sources should be queried by the generic sensor channels (`SENSOR_CHAN_VOLTAGE`, etc), or the fuel guage specific channels (`SENSOR_CHAN_GAUGE_*`). Signed-off-by: Jordan Yates <jordan@embeint.com>
Add support for the `FUEL_GAUGE_TEMPERATURE` property. Signed-off-by: Jordan Yates <jordan@embeint.com>
Query the configured data sources for capacity and soc information before falling back to the composite fuel gauge configuration. This means the battery properties are no longer required. Signed-off-by: Jordan Yates <jordan@embeint.com>
JordanYates
force-pushed
the
250410_fuel_gauge_comp_tick
branch
from
a43f783 to
b34fe1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that data is consistent across multiple sequential calls to
fuel_gauge_get_prop, sensor_fetch is only called if a certain time period has passed since the previous sampling. This emulates the tick-based sampling of most dedicated fuel-gauge devices.Instead of explicitly specifying the source for the voltage and current channels, specify primary and secondary data sources. If the requested sensor channel does not exist on the primary source, the secondary source will be tried.
Choose whether the data sources should be queried by the generic sensor channels (
SENSOR_CHAN_VOLTAGE, etc), or the fuel gauge specific channels (SENSOR_CHAN_GAUGE_*).Add support for the
FUEL_GAUGE_TEMPERATUREproperty.More flexible alternative to #83859.
The motivation for this PR is the desire to access core functionality of the existing in-tree nPM1300 driver (which implements the sensor API using
SENSOR_CHAN_GAUGE_*channels) through the fuel gauge API, together with extending it to support SoC lookup.