-
Notifications
You must be signed in to change notification settings - Fork 7.6k
boards: nxp: unify NXP board naming in board.yml #88368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
boards: nxp: unify NXP board naming in board.yml #88368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this change needed?
@@ -1,6 +1,6 @@ | |||
board: | |||
name: imx8mp_evk | |||
full_name: i.MX8MP EVK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the board name is the same with the information in nxp.com, so I don't think we need to update the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the board name is the same with the information in nxp.com, so I don't think we need to update the name.
"-EVK" is written on board labels. Also it used for other NXP board naming.
Actually no matter for me, just to use the common approach.
@butok I don't think this is necessary. A name is just a human readable form to identify the board. At least for i.MX8 boards I would prefer to keep them like that. |
The NXP board naming in Zephyr documentation is not uniform even within families. Various inconsistencies exist such as using hyphens or spaces, including revisions or not, and using core names or omitting them. See https://docs.zephyrproject.org/latest/boards/nxp/index.htm The current Zephyr NXP documentation board naming chaos is caused by different variants used on board labels, website titles, board documentation, and using short and long naming forms. "We need to decide if we want to fix this inconsistency at least in the Zephyr documentation." Anyone is welcome to provide their own solution via a Pull Request, but it should be applicable to all NXP Zephyr boards. |
Unify full_name content in NXP board.yml to be consistent with the rest of NXP boards. Signed-off-by: Andrej Butok <andrey.butok@nxp.com>
c8ac812
to
0914926
Compare
my concerns addressed, no changes for my area so dismissing my review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use these names to align with the board names on NXP.com:
@@ -1,6 +1,6 @@ | |||
board: | |||
name: imx91_evk | |||
full_name: i.MX91 EVK | |||
full_name: i.MX91-EVK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
full_name: i.MX91-EVK | |
full_name: i.MX91EVK |
See https://www.nxp.com/design/design-center/development-boards-and-designs/i.MX91EVK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,6 +1,6 @@ | |||
board: | |||
name: imx93_evk | |||
full_name: i.MX93 EVK | |||
full_name: i.MX93-EVK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
full_name: i.MX93-EVK | |
full_name: i.MX93EVK |
see https://www.nxp.com/design/design-center/development-boards-and-designs/i.MX93EVK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Unify full_name content in NXP board.yml to be consistent with the rest of NXP boards.