Skip to content

dts: renesas: ra: remove all interrupts definition from SoC dtsi #87316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

thenguyenyf
Copy link
Contributor

@thenguyenyf thenguyenyf commented Mar 19, 2025

Because Renesas RA device have a dynamic link mechanism between IP event and the NVIC interrupt line, it is better to move all interrupts definition to board layers. If user would like to add overlay for enable a device node, they should refer to interrupts description in dts binding to add correct interrupts information (specifier, name, ...).

To add interrupts description, #87672 is being prepared.

This PR to remove all interrupts properties from RA8x1 device SoC dtsi, move it into .dts and .overlay for enabled node, affects the following boards:

  • ek_ra8m1
  • ek_ra8d1
  • mck_ra8t1

@zephyrbot zephyrbot added platform: Renesas RA Renesas Electronics Corporation, RA area: UART Universal Asynchronous Receiver-Transmitter area: File System area: Shields Shields (add-on boards) area: ADC Analog-to-Digital Converter (ADC) area: Samples Samples area: Counter area: SPI SPI bus labels Mar 19, 2025
Copy link
Member

@soburi soburi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever possible, commit in units that will not cause CI to fail for each commit.
In other words, instead of splitting commits into adds and deletes, make a commit that combines adds and deletes for each item you want to change.
Otherwise, it will become difficult to understand the intention of each commit.

@thenguyenyf
Copy link
Contributor Author

Whenever possible, commit in units that will not cause CI to fail for each commit. In other words, instead of splitting commits into adds and deletes, make a commit that combines adds and deletes for each item you want to change. Otherwise, it will become difficult to understand the intention of each commit.

Let me make clear your change suggestion: Do you mean that the delete and update interrupts properties should be done in 1 commit as it possible? So, this PR should be change to one of following:

  • 1 commit for board + SoC interrupts update (includes deletion in SoC dtsi and update in board dts) and commits to update all board overlays?
  • 1 commit includes update for SoC dtsi, board dts and all board overlays?

@soburi
Copy link
Member

soburi commented May 6, 2025

Whenever possible, commit in units that will not cause CI to fail for each commit. In other words, instead of splitting commits into adds and deletes, make a commit that combines adds and deletes for each item you want to change. Otherwise, it will become difficult to understand the intention of each commit.

Let me make clear your change suggestion: Do you mean that the delete and update interrupts properties should be done in 1 commit as it possible? So, this PR should be change to one of following:

* 1 commit for board + SoC interrupts update (includes deletion in SoC dtsi and update in board dts) and commits to update all board overlays?

* 1 commit includes update for SoC dtsi, board dts and all board overlays?

I think what's happening here is "moving" rather than "adding and deleting".
Please group by what was "moved".

It looks like there are some changes to the PWM and port-irq values, so I think it would be fine to split these up.

Also, rtkmipilcdb00000be contains content that is not included in the PR description, so it might be a good idea to make it a separate PR.

de-nordic
de-nordic previously approved these changes Jun 3, 2025
Copy link
Contributor

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ext2 tests look ok

@thenguyenyf thenguyenyf force-pushed the ra8x1_remove_interrupt_from_soc_dtsi branch from 65ba0d6 to b0d7080 Compare June 4, 2025 02:08
@thenguyenyf thenguyenyf force-pushed the ra8x1_remove_interrupt_from_soc_dtsi branch from b0d7080 to 76eb6b4 Compare June 4, 2025 02:15
@thenguyenyf thenguyenyf requested review from de-nordic and soburi June 4, 2025 02:15
Because of the complexity of the interrupt routing on Renesas RA SoCs,
it is better to not define a static information for all board variant of
Renesas RA devices at the SoC layer.
This commit to move all existing interrupts propeties of Renesas RA8x1
series from SoC to the board dts for enabled node only.
Affect to these boards:
- ek_ra8m1
- ek_ra8d1
- mck_ra8t1

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add interrupts information for these boards:
- ek_ra8m1
- ek_ra8d1
- mck_ra8t1

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add interrupts information for ek_ra8m1 board

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add interrupts information for these boards:
- ek_ra8d1
- mck_ra8t1

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add interrupts information for these boards:
- ek_ra8m1
- ek_ra8d1

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add interrupts information for these boards:
- ek_ra8m1
- ek_ra8d1
- mck_ra8t1

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
@thenguyenyf thenguyenyf force-pushed the ra8x1_remove_interrupt_from_soc_dtsi branch from 76eb6b4 to 913595f Compare June 12, 2025 03:58
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ADC Analog-to-Digital Converter (ADC) area: Counter area: File System area: Samples Samples area: Shields Shields (add-on boards) area: SPI SPI bus area: UART Universal Asynchronous Receiver-Transmitter platform: Renesas RA Renesas Electronics Corporation, RA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants