-
Notifications
You must be signed in to change notification settings - Fork 7.6k
dts: renesas: ra: remove all interrupts definition from SoC dtsi #87316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
dts: renesas: ra: remove all interrupts definition from SoC dtsi #87316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever possible, commit in units that will not cause CI to fail for each commit.
In other words, instead of splitting commits into adds and deletes, make a commit that combines adds and deletes for each item you want to change.
Otherwise, it will become difficult to understand the intention of each commit.
Let me make clear your change suggestion: Do you mean that the delete and update interrupts properties should be done in 1 commit as it possible? So, this PR should be change to one of following:
|
I think what's happening here is "moving" rather than "adding and deleting". It looks like there are some changes to the PWM and port-irq values, so I think it would be fine to split these up. Also, rtkmipilcdb00000be contains content that is not included in the PR description, so it might be a good idea to make it a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ext2 tests look ok
65ba0d6
to
b0d7080
Compare
b0d7080
to
76eb6b4
Compare
Because of the complexity of the interrupt routing on Renesas RA SoCs, it is better to not define a static information for all board variant of Renesas RA devices at the SoC layer. This commit to move all existing interrupts propeties of Renesas RA8x1 series from SoC to the board dts for enabled node only. Affect to these boards: - ek_ra8m1 - ek_ra8d1 - mck_ra8t1 Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add interrupts information for these boards: - ek_ra8m1 - ek_ra8d1 - mck_ra8t1 Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add interrupts information for ek_ra8m1 board Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add interrupts information for these boards: - ek_ra8d1 - mck_ra8t1 Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add interrupts information for these boards: - ek_ra8m1 - ek_ra8d1 Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add interrupts information for these boards: - ek_ra8m1 - ek_ra8d1 - mck_ra8t1 Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
76eb6b4
to
913595f
Compare
|
Because Renesas RA device have a dynamic link mechanism between IP event and the NVIC interrupt line, it is better to move all interrupts definition to board layers. If user would like to add overlay for enable a device node, they should refer to interrupts description in dts binding to add correct interrupts information (specifier, name, ...).
To add interrupts description, #87672 is being prepared.
This PR to remove all interrupts properties from RA8x1 device SoC dtsi, move it into .dts and .overlay for enabled node, affects the following boards: