Skip to content

boards: adafruit: add initial support for esp32 feather v2 #87177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

boards: adafruit: add initial support for esp32 feather v2 #87177

wants to merge 1 commit into from
+459 −0

Conversation

lvoytek
Copy link

@lvoytek lvoytek commented Mar 16, 2025

The Adafruit ESP32 Feather V2 is a board that uses the Feather standard layout. It uses an ESP32-PICO v3 02 module, and includes a USB-C connector, LiPo battery charger, NeoPixel RGB LED, and STEMMA QT connector.

Not to be confused with the adafruit esp32s3 feather, which I noticed was just added a few days ago :)

@zephyrbot zephyrbot added area: LED Label to identify LED subsystem area: Samples Samples labels Mar 16, 2025
@github-actions GitHub Actions
Copy link

Hello @lvoytek, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

nordicjm
nordicjm reviewed Mar 17, 2025
View reviewed changes
boards/adafruit/feather_esp32_v2/board.yml Outdated
Comment on lines 2 to 3
name: adafruit_feather_esp32_v2
full_name: Adafruit ESP32 Feather V2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be adafruit_feather_esp32 and use a board revision https://docs.zephyrproject.org/latest/hardware/porting/board_porting.html#multiple-board-revisions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated naming and added a single default "2" revision. I know it's deprecated but if there's interest I could also port V1 since I still own several of them :)

@lvoytek lvoytek closed this Apr 27, 2025
@lvoytek lvoytek reopened this Apr 27, 2025
@kartben kartben requested a review from sylvioalves May 2, 2025 19:50
sylvioalves
sylvioalves reviewed May 5, 2025
View reviewed changes
sylvioalves
sylvioalves reviewed May 5, 2025
View reviewed changes
@lvoytek
Copy link
Author

lvoytek commented May 5, 2025

Thanks for the review @sylvioalves! Updated based on your comments

kartben
kartben previously approved these changes May 6, 2025
View reviewed changes
boards/adafruit/feather_esp32/board.yml Outdated
@@ -0,0 +1,11 @@
board:
name: adafruit_feather_esp32
full_name: Adafruit ESP32 Feather
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: all the other supported Feather boards are named "Adafruit Feather XXX"

Suggested change
full_name: Adafruit ESP32 Feather
full_name: Adafruit Feather ESP32

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. I originally named it based on the adafruit.com listing but now I see all ESP32 feathers there now use the "Adafruit ESP32... Feather" convention. It's definitely better to have naming consistency here, so I've updated the name in the yml and dts files :)

@kartben kartben requested a review from sylvioalves May 6, 2025 12:17
@lvoytek
boards: adafruit: add initial support for esp32 feather v2
8a71c33 
The Adafruit ESP32 Feather V2 is a board that uses the Feather standard
layout. It uses an ESP32-PICO v3 02 module, and includes a USB-C
connector, LiPo battery charger, NeoPixel RGB LED, and STEMMA QT
connector.

Signed-off-by: Lena Voytek <lena@voytek.dev>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2025

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nordicjm nordicjm nordicjm left review comments

@kartben kartben kartben left review comments

@Mani-Sadhasivam Mani-Sadhasivam Awaiting requested review from Mani-Sadhasivam

@nashif nashif Awaiting requested review from nashif

@simonguinot simonguinot Awaiting requested review from simonguinot

@sylvioalves sylvioalves Awaiting requested review from sylvioalves

At least 2 approving reviews are required to merge this pull request.

Assignees

@Mani-Sadhasivam Mani-Sadhasivam

@simonguinot simonguinot

Labels
area: LED Label to identify LED subsystem area: Samples Samples Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lvoytek @kartben @sylvioalves @nordicjm @Mani-Sadhasivam @simonguinot @zephyrbot