Skip to content

boards: linkw: fix west flash with minichlink #87141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

VynDragon
Copy link
Collaborator

@VynDragon VynDragon commented Mar 14, 2025

This fixes west flash for this board and should be present for every ch32v208 board.

Dependent on #87138

@VynDragon
Copy link
Collaborator Author

Failure is nonsense, there is no soc.h here and this didnt fail on the main PR.

@kartben
Copy link
Collaborator

kartben commented Mar 19, 2025

Would be great to work a bit on the commit message so that it actually describes the fix in the description
Also looks like you're changing the default runner which is unrelated to the fix, right?

@kartben
Copy link
Collaborator

kartben commented Mar 19, 2025

Failure is nonsense, there is no soc.h here and this didnt fail on the main PR.

This should be fixed in main, I've re-triggered CI

@VynDragon
Copy link
Collaborator Author

Would be great to work a bit on the commit message so that it actually describes the fix in the description Also looks like you're changing the default runner which is unrelated to the fix, right?

There is not much to say except 'ch32v208 needs reset disabled or it doesnt work' :/
Yea, ill separate the reordering, it was always intended to use minichlink in priority but i hadn't figured why it wasn't working until the CH32V303 PR so I had left the file to default. In theory debug should also be minichlink but i haven't figured how to get that working right either.

This fixes west flash, as it doesnt work without reset for this board
and should be present for every ch32v208 board

Signed-off-by: Camille BAUD <mail@massdriver.space>
change default runner to minichlink

Signed-off-by: Camille BAUD <mail@massdriver.space>
@VynDragon VynDragon force-pushed the ch32v208_west_flash branch from 87da50a to fd60c72 Compare March 19, 2025 12:23
@VynDragon
Copy link
Collaborator Author

VynDragon commented Mar 19, 2025

Fixed. Note this is dependent on #85395 and another future PR (coming, fix for a possible if implementing WWATCHDOG off by 1 mtvec thing and setting the flash address) to work as intended, otherwise it goes into code ram.

@VynDragon
Copy link
Collaborator Author

VynDragon commented Mar 20, 2025

Found out this is also fixed by combination of #87345 and #85395 due to not using 0x0 anymore (which was also possibly me getting confused in the first place), closing, sorry for the waste of time...

@VynDragon VynDragon closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants