drivers: video: imagers/cci/imx219: easier image sensor contribution

drivers/video/CMakeLists.txt

@@ -14,6 +14,7 @@ zephyr_library_sources_ifdef(CONFIG_VIDEO_GC2145	gc2145.c)
 zephyr_library_sources_ifdef(CONFIG_VIDEO_STM32_DCMI	video_stm32_dcmi.c)
 zephyr_library_sources_ifdef(CONFIG_VIDEO_OV5640	ov5640.c)
 zephyr_library_sources_ifdef(CONFIG_VIDEO_OV7670	ov7670.c)
+zephyr_library_sources_ifdef(CONFIG_VIDEO_IMX219	imx219.c)
 zephyr_library_sources_ifdef(CONFIG_VIDEO_ESP32		video_esp32_dvp.c)
 zephyr_library_sources_ifdef(CONFIG_VIDEO_MCUX_SDMA	video_mcux_smartdma.c)
 zephyr_library_sources_ifdef(CONFIG_VIDEO_EMUL_IMAGER	video_emul_imager.c)

drivers/video/Kconfig

@@ -58,6 +58,8 @@ source "drivers/video/Kconfig.mcux_mipi_csi2rx"
 
 source "drivers/video/Kconfig.sw_generator"
 
+source "drivers/video/Kconfig.imx219"
+
 source "drivers/video/Kconfig.mt9m114"
 
 source "drivers/video/Kconfig.ov7725"

drivers/video/Kconfig.emul_imager

@@ -5,6 +5,7 @@ config VIDEO_EMUL_IMAGER
 	bool "Software implementation of an imager"
 	depends on DT_HAS_ZEPHYR_VIDEO_EMUL_IMAGER_ENABLED
 	default y
+	depends on EMUL
 	help
 	  Enable driver for the emulated Imager.
 

drivers/video/Kconfig.imx219

@@ -0,0 +1,10 @@
+# Copyright (c) 2024-2025 tinyVision.ai Inc.
+# SPDX-License-Identifier: Apache-2.0
+
+config VIDEO_IMX219
+	bool "IMX219 8 MP CMOS image sensor"
+	select I2C
+	depends on DT_HAS_SONY_IMX219_ENABLED
+	default y
+	help
+	  Enable the driver for the Sony IMX219 8 Mega-Pixel CMOS image sensor

drivers/video/imx219.c

@@ -0,0 +1,270 @@
+/*
+ * Copyright (c) 2024-2025 tinyVision.ai Inc.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+#define DT_DRV_COMPAT sony_imx219
+
+#include <zephyr/device.h>
+#include <zephyr/drivers/i2c.h>
+#include <zephyr/drivers/video.h>
+#include <zephyr/drivers/video-controls.h>
+#include <zephyr/kernel.h>
+#include <zephyr/sys/byteorder.h>
+#include <zephyr/logging/log.h>
+
+#include "video_imager.h"
+
+LOG_MODULE_REGISTER(imx219, CONFIG_VIDEO_LOG_LEVEL);
+
+#define IMX219_FULL_WIDTH		3280
+#define IMX219_FULL_HEIGHT		2464
+
+#define IMX219_REG_CHIP_ID		VIDEO_CCI(0x0000, 2, 2)
+#define IMX219_REG_SOFTWARE_RESET	VIDEO_CCI(0x0103, 2, 1)
+#define IMX219_REG_MODE_SELECT		VIDEO_CCI(0x0100, 2, 1)
+#define IMX219_REG_ANALOG_GAIN		VIDEO_CCI(0x0157, 2, 1)
+#define IMX219_REG_DIGITAL_GAIN		VIDEO_CCI(0x0158, 2, 2)
+#define IMX219_REG_INTEGRATION_TIME	VIDEO_CCI(0x015A, 2, 2)
+#define IMX219_REG_TESTPATTERN		VIDEO_CCI(0x0600, 2, 2)
+#define IMX219_REG_MODE_SELECT		VIDEO_CCI(0x0100, 2, 1)
+#define IMX219_REG_CSI_LANE_MODE	VIDEO_CCI(0x0114, 2, 1)
+#define IMX219_REG_DPHY_CTRL		VIDEO_CCI(0x0128, 2, 1)
+#define IMX219_REG_EXCK_FREQ		VIDEO_CCI(0x012a, 2, 2)
+#define IMX219_REG_PREPLLCK_VT_DIV	VIDEO_CCI(0x0304, 2, 1)
+#define IMX219_REG_PREPLLCK_OP_DIV	VIDEO_CCI(0x0305, 2, 1)
+#define IMX219_REG_OPPXCK_DIV		VIDEO_CCI(0x0309, 2, 1)
+#define IMX219_REG_VTPXCK_DIV		VIDEO_CCI(0x0301, 2, 1)
+#define IMX219_REG_VTSYCK_DIV		VIDEO_CCI(0x0303, 2, 1)
+#define IMX219_REG_OPSYCK_DIV		VIDEO_CCI(0x030b, 2, 1)
+#define IMX219_REG_PLL_VT_MPY		VIDEO_CCI(0x0306, 2, 2)
+#define IMX219_REG_PLL_OP_MPY		VIDEO_CCI(0x030c, 2, 2)
+#define IMX219_REG_LINE_LENGTH_A	VIDEO_CCI(0x0162, 2, 2)
+#define IMX219_REG_CSI_DATA_FORMAT_A	VIDEO_CCI(0x018c, 2, 2)
+#define IMX219_REG_BINNING_MODE_H	VIDEO_CCI(0x0174, 2, 1)
+#define IMX219_REG_BINNING_MODE_V	VIDEO_CCI(0x0175, 2, 1)
+#define IMX219_REG_ORIENTATION		VIDEO_CCI(0x0172, 2, 1)
+#define IMX219_REG_FRM_LENGTH_A		VIDEO_CCI(0x0160, 2, 2)
+#define IMX219_REG_FRM_LENGTH_A		VIDEO_CCI(0x0160, 2, 2)
+#define IMX219_REG_X_ADD_STA_A		VIDEO_CCI(0x0164, 2, 2)
+#define IMX219_REG_X_ADD_END_A		VIDEO_CCI(0x0166, 2, 2)
+#define IMX219_REG_Y_ADD_STA_A		VIDEO_CCI(0x0168, 2, 2)
+#define IMX219_REG_Y_ADD_END_A		VIDEO_CCI(0x016a, 2, 2)
+#define IMX219_REG_X_OUTPUT_SIZE	VIDEO_CCI(0x016c, 2, 2)
+#define IMX219_REG_Y_OUTPUT_SIZE	VIDEO_CCI(0x016e, 2, 2)
+#define IMX219_REG_X_ODD_INC_A		VIDEO_CCI(0x0170, 2, 1)
+#define IMX219_REG_Y_ODD_INC_A		VIDEO_CCI(0x0171, 2, 1)
+
+/* Registers to crop down a resolution to a centered width and height */
+#define IMX219_REGS_CROP(width, height)                                                            \
+	{IMX219_REG_X_ADD_STA_A, (IMX219_FULL_WIDTH - (width)) / 2},                               \
+	{IMX219_REG_X_ADD_END_A, (IMX219_FULL_WIDTH + (width)) / 2 - 1},                           \
+	{IMX219_REG_Y_ADD_STA_A, (IMX219_FULL_HEIGHT - (height)) / 2},                             \
+	{IMX219_REG_Y_ADD_END_A, (IMX219_FULL_HEIGHT + (height)) / 2 - 1}
+
+static const struct video_reg init_regs[] = {
+	{IMX219_REG_MODE_SELECT, 0x00},		/* Standby */
+
+	/* Enable access to registers from 0x3000 to 0x5fff */
+	{VIDEO_CCI(0x30eb, 2, 1), 0x05},
+	{VIDEO_CCI(0x30eb, 2, 1), 0x0c},
+	{VIDEO_CCI(0x300a, 2, 1), 0xff},
+	{VIDEO_CCI(0x300b, 2, 1), 0xff},
+	{VIDEO_CCI(0x30eb, 2, 1), 0x05},
+	{VIDEO_CCI(0x30eb, 2, 1), 0x09},
+
+	/* MIPI configuration registers */
+	{IMX219_REG_CSI_LANE_MODE, 0x01},	/* 2 Lanes */
+	{IMX219_REG_DPHY_CTRL, 0x00},		/* Timing auto */
+
+	/* Clock configuration registers */
+	{IMX219_REG_EXCK_FREQ, 24 << 8},	/* 24 MHz */
+	{IMX219_REG_PREPLLCK_VT_DIV, 0x03},	/* Auto */
+	{IMX219_REG_PREPLLCK_OP_DIV, 0x03},	/* Auto */
+	{IMX219_REG_OPPXCK_DIV, 10},		/* 10-bits per pixel */
+	{IMX219_REG_VTPXCK_DIV, 5},
+	{IMX219_REG_VTSYCK_DIV, 1},
+	{IMX219_REG_OPSYCK_DIV, 1},
+	{IMX219_REG_PLL_VT_MPY, 32},		/* Pixel/Sys clock multiplier */
+	{IMX219_REG_PLL_OP_MPY, 50},		/* Output clock multiplier */
+
+	/* Undocumented registers */
+	{VIDEO_CCI(0x455e, 2, 1), 0x00},
+	{VIDEO_CCI(0x471e, 2, 1), 0x4b},
+	{VIDEO_CCI(0x4767, 2, 1), 0x0f},
+	{VIDEO_CCI(0x4750, 2, 1), 0x14},
+	{VIDEO_CCI(0x4540, 2, 1), 0x00},
+	{VIDEO_CCI(0x47b4, 2, 1), 0x14},
+	{VIDEO_CCI(0x4713, 2, 1), 0x30},
+	{VIDEO_CCI(0x478b, 2, 1), 0x10},
+	{VIDEO_CCI(0x478f, 2, 1), 0x10},
+	{VIDEO_CCI(0x4793, 2, 1), 0x10},
+	{VIDEO_CCI(0x4797, 2, 1), 0x0e},
+	{VIDEO_CCI(0x479b, 2, 1), 0x0e},
+
+	/* Timing and format registers */
+	{IMX219_REG_LINE_LENGTH_A, 3448},
+	{IMX219_REG_X_ODD_INC_A, 1},
+	{IMX219_REG_Y_ODD_INC_A, 1},
+	{IMX219_REG_CSI_DATA_FORMAT_A, (10 << 8) | 10}, /* 10-bits per pixels */
+
+	/* Custom defaults */
+	{IMX219_REG_BINNING_MODE_H, 0x00},
+	{IMX219_REG_BINNING_MODE_V, 0x00},
+	{IMX219_REG_DIGITAL_GAIN, 5000},
+	{IMX219_REG_ANALOG_GAIN, 240},
+	{IMX219_REG_INTEGRATION_TIME, 1600},
+	{IMX219_REG_ORIENTATION, 0x03},
+
+	{0},
+};
+
+static const struct video_reg size_1920x1080[] = {
+	IMX219_REGS_CROP(1920, 1080),
+	{IMX219_REG_X_OUTPUT_SIZE, 1920},
+	{IMX219_REG_Y_OUTPUT_SIZE, 1080},
+	{IMX219_REG_FRM_LENGTH_A, 1080 + 120},
+	{0},
+};
+
+static const struct video_reg size_640x480[] = {
+	IMX219_REGS_CROP(640, 480),
+	{IMX219_REG_X_OUTPUT_SIZE, 640},
+	{IMX219_REG_Y_OUTPUT_SIZE, 480},
+	{IMX219_REG_FRM_LENGTH_A, 480 + 120},
+	{0},
+};
+
+static const struct video_imager_mode modes_1920x1080[] = {
+	{.fps = 30, .regs = {size_1920x1080}},
+	{0},
+};
+
+static const struct video_imager_mode modes_640x480[] = {
+	{.fps = 30, .regs = {size_640x480}},
+	{0},
+};
+
+static const struct video_imager_mode *modes[] = {
+	modes_1920x1080,
+	modes_640x480,
+	NULL,
+};
+
+static const struct video_format_cap fmts[] = {
+	VIDEO_IMAGER_FORMAT_CAP(VIDEO_PIX_FMT_BGGR8, 1920, 1080),
+	VIDEO_IMAGER_FORMAT_CAP(VIDEO_PIX_FMT_BGGR8, 640, 480),
+	{0},
+};
+
+static int imx219_set_stream(const struct device *dev, bool on)
+{
+	struct video_imager_data *data = dev->data;
+
+	return video_cci_write_reg(data->i2c, IMX219_REG_MODE_SELECT, on ? 0x01 : 0x00);
+}
+
+static int imx219_set_ctrl(const struct device *dev, unsigned int cid, void *value)
+{
+	struct video_imager_data *data = dev->data;
+
+	switch (cid) {
+	case VIDEO_CID_EXPOSURE:
+		return video_cci_write_reg(data->i2c, IMX219_REG_INTEGRATION_TIME, (int)value);
+	case VIDEO_CID_GAIN:
+		return video_cci_write_reg(data->i2c, IMX219_REG_ANALOG_GAIN, (int)value);
+	case VIDEO_CID_TEST_PATTERN:
+		return video_cci_write_reg(data->i2c, IMX219_REG_TESTPATTERN, (int)value);
+	default:
+		LOG_WRN("Control not supported");
+		return -ENOTSUP;
+	}
+}
+
+static int imx219_get_ctrl(const struct device *dev, unsigned int cid, void *value)
+{
+	struct video_imager_data *data = dev->data;
+	uint32_t reg;
+	int ret;
+
+	switch (cid) {
+	case VIDEO_CID_EXPOSURE:
+		/* Values for normal frame rate, different range for low frame rate mode */
+		ret = video_read_reg(data->i2c, IMX219_REG_INTEGRATION_TIME, &reg);
+		*(uint32_t *)value = reg;
+		return ret;
+	case VIDEO_CID_GAIN:
+		ret = video_read_reg(data->i2c, IMX219_REG_ANALOG_GAIN, &reg);
+		*(uint32_t *)value = reg;
+		return ret;
+	default:
+		LOG_WRN("Control not supported");
+		return -ENOTSUP;
+	}
+}
+
+static const DEVICE_API(video, imx219_driver_api) = {
+	/* Implementation common to all sensors */
+	.set_format = video_imager_set_fmt,
+	.get_format = video_imager_get_fmt,
+	.get_caps = video_imager_get_caps,
+	.set_frmival = video_imager_set_frmival,
+	.get_frmival = video_imager_get_frmival,
+	.enum_frmival = video_imager_enum_frmival,
+	/* Implementation specific o this sensor */
+	.set_stream = imx219_set_stream,
+	.set_ctrl = imx219_set_ctrl,
+	.get_ctrl = imx219_get_ctrl,
+};
+
+static int imx219_init(const struct device *dev)
+{
+	struct video_imager_data *data = dev->data;
+	uint32_t reg;
+	int ret;
+
+	if (!device_is_ready(data->i2c->bus)) {
+		LOG_ERR("I2C device %s is not ready", data->i2c->bus->name);
+		return -ENODEV;
+	}
+
+	k_sleep(K_MSEC(1));
+
+	ret = video_cci_write_reg(data->i2c, IMX219_REG_SOFTWARE_RESET, 1);
+	if (ret != 0) {
+		goto err;
+	}
+
+	/* Initializing time of silicon (t5): 32000 clock cycles, 5.3 msec for 6 MHz */
+	k_sleep(K_MSEC(6));
+
+	ret = video_cci_read_reg(data->i2c, IMX219_REG_CHIP_ID, &reg);
+	if (ret != 0) {
+		goto err;
+	}
+
+	if (reg != 0x0219) {
+		LOG_ERR("Wrong chip ID %04x", reg);
+		return -ENODEV;
+	}
+
+	return video_imager_init(dev, init_regs, 0);
+err:
+	LOG_ERR("Error during %s initialization: %s", dev->name, strerror(-ret));
+	return ret;
+
+}
+
+#define IMX219_INIT(n)                                                                             \
+	static struct i2c_dt_spec i2c_##n = I2C_DT_SPEC_INST_GET(n);                               \
+	static struct video_imager_data data_##n = {                                               \
+		.i2c = &i2c_##n,                                                                   \
+		.fmts = fmts,                                                                      \
+		.modes = modes,                                                                    \
+	};                                                                                         \
+                                                                                                   \
+	DEVICE_DT_INST_DEFINE(n, &imx219_init, NULL, &data_##n, NULL, POST_KERNEL,                 \
+			      CONFIG_VIDEO_INIT_PRIORITY, &imx219_driver_api);
+
+DT_INST_FOREACH_STATUS_OKAY(IMX219_INIT)