lorawan: pass callback pointer to callback invocation #86868
+44
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mniestroj
force-pushed
the
lorawan-pass-callback
branch
from
9aebdd0 to
21fb262
Compare
mniestroj
changed the title
JordanYates
requested changes
Mar 10, 2025
mniestroj
force-pushed
the
lorawan-pass-callback
branch
from
21fb262 to
826c387
Compare
mniestroj
force-pushed
the
lorawan-pass-callback
branch
2 times, most recently
from
4320f69 to
2846066
Compare
mniestroj
force-pushed
the
lorawan-pass-callback
branch
2 times, most recently
from
d6e6ced to
28010b0
Compare
JordanYates
reviewed
Mar 19, 2025
mniestroj
force-pushed
the
lorawan-pass-callback
branch
from
28010b0 to
dd39249
Compare
nordicjm
reviewed
Mar 19, 2025
| @@ -122,7 +123,8 @@ static void smp_lorawan_uplink_thread(void *p1, void *p2, void *p3) | |||
| } | |||
| #endif | |||
|
|
|||
| static void smp_lorawan_downlink(uint8_t port, uint8_t flags, int16_t rssi, int8_t snr, | |||
| static void smp_lorawan_downlink(struct lorawan_downlink_cb *cb, | |||
| uint8_t port, uint8_t flags, int16_t rssi, int8_t snr, | |||
| uint8_t len, const uint8_t *hex_data) | |||
| { | |||
| ARG_UNUSED(flags); | |||
mniestroj
force-pushed
the
lorawan-pass-callback
branch
from
dd39249 to
1684921
Compare
mniestroj
force-pushed
the
lorawan-pass-callback
branch
from
1684921 to
0cfdc1a
Compare
JordanYates
reviewed
Apr 17, 2025
mniestroj
force-pushed
the
lorawan-pass-callback
branch
from
0cfdc1a to
754c9fd
Compare
JordanYates
approved these changes
Apr 17, 2025
This allows to make use of CONTAINER_OF() macro when registered 'struct lorawan_downlink_cb' is part of another structure. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
This structure has updated callback, with additional parameter. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
mniestroj
force-pushed
the
lorawan-pass-callback
branch
from
754c9fd to
fdd541b
Compare
martinjaeger
requested changes
Apr 23, 2025
| @@ -305,6 +305,13 @@ SPI | |||
| Other subsystems | |||
| **************** | |||
|
|
|||
| LoRa | |||
There was a problem hiding this comment.
Suggested change
| LoRa | |
| LoRaWAN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to make use of
CONTAINER_OF()macro when registeredstruct lorawan_downlink_cbispart of another structure.