Bluetooth: CAP: Add cap_unicast_group API #86014
Open
+1,105
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
cap_unicast_group
branch
10 times, most recently
from
f84f903 to
da10ddf
Compare
zephyrbot
added
area: Bluetooth
Release Notes
zephyrbot
requested review from
asbjornsabo,
babrsn,
Casper-Bonde-Bose,
fabiobaltieri,
fredrikdanebjer,
jhedberg,
jthm-ot,
kartben,
larsgk,
MariuszSkamra,
nashif,
niym-ot,
pin-zephyr and
sjanc
Thalley
force-pushed
the
cap_unicast_group
branch
8 times, most recently
from
4a3d5d5 to
8d2a059
Compare
Thalley
force-pushed
the
cap_unicast_group
branch
from
8d2a059 to
f2709a5
Compare
Thalley
force-pushed
the
cap_unicast_group
branch
from
f2709a5 to
8e21d26
Compare
Comment on lines
+106
to
+108
| free(group_param->params[0].rx_param->stream); | ||
| free(group_param->params[0].rx_param); |
There was a problem hiding this comment.
The cleanup in the test fixture frees only the first parameter's allocations. If multiple stream parameters are allocated, this may lead to memory leaks. Consider iterating over all allocated stream parameters for proper deallocation.
Suggested change
| free(group_param->params[0].rx_param->stream); | |
| free(group_param->params[0].rx_param); | |
| for (size_t i = 0; i < group_param->params_count; i++) { | |
| free(group_param->params[i].rx_param->stream); | |
| free(group_param->params[i].rx_param); | |
| } |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
There is only a single call to calloc for these, so there should only be a single call to free for these
Thalley
force-pushed
the
cap_unicast_group
branch
2 times, most recently
from
1f6a399 to
6407e31
Compare
jthm-ot
previously approved these changes
May 20, 2025
Adds a new abstract struct for unicast group that is specific for CAP. The difference between this and the BAP unicast group, is that the parameters are CAP streams and thus ensuring that the streams in the group adhere to the additional requirements that CAP has on top of BAP. This also adds foreach functions for both CAP and BAP to allow users to iterate on the streams in the abstract groups. Various samples, modules and tests have been updated to use the CAP struct and API. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
cap_unicast_group
branch
from
6407e31 to
c2c95ed
Compare
|
Added 2 new functions to iterate on the streams in the BAP and CAP groups as well. Used by #85642 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new abstract struct for unicast group that is specific for CAP. The difference between this and the BAP unicast group, is that the parameters are CAP streams and thus ensuring that the streams in the group adhere to the additional requirements that CAP has on top of BAP.
Various samples, modules and tests have been updated to use the CAP struct and API.