-
Notifications
You must be signed in to change notification settings - Fork 7.4k
boards: support Arduino Portenta C33 #85337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0339d5e
to
c323a15
Compare
Is there a reason to use |
CONFIG_UART_INTERRUPT_DRIVEN=y | ||
CONFIG_CONSOLE=y | ||
|
||
CONFIG_USE_DT_CODE_PARTITION=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CONFIG_USE_DT_CODE_PARTITION=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be set to preserve the default functionality (with dfu bootloader). Is there another way to achieve the same result?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is required then needs to go in Kconfig and the board Kconfig select it
return 0; | ||
} | ||
|
||
SYS_INIT(eth_pwm_clock_enable, POST_KERNEL, CONFIG_CLOCK_CONTROL_PWM_INIT_PRIORITY); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have a common .c file with all of the code functions then use a board hook to run a function which runs them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the USB init file (which was a dirty solution anyway), will apply #85294 whrn it gets merged
When we had to decide which firmware to flash on the network companion, esp-at for ESP32C3 was brand new and very unstable, so we took the other direction 🥲 |
e420a66
to
8c92038
Compare
1506fd3
to
db751b1
Compare
1713673
to
21007d6
Compare
Review and CI comments addressed. @nordicjm please revisit. |
zephyr_library() | ||
zephyr_library_sources_ifdef(CONFIG_NETWORKING board.c) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zephyr_library() | |
zephyr_library_sources_ifdef(CONFIG_NETWORKING board.c) | |
if(CONFIG_NETWORKING) | |
zephyr_library() | |
zephyr_library_sources(board.c) | |
endif() |
otherwise will have an empty library warning when NETWORKING is disabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. Having a board.c
conditional on NETWORKING
looked strange as well, so I renamed the file to eth_clock.c
and dropped the library step.
Tested: * GPIO * UART * USB (using USB_DEVICE_NEXT) * BLE Signed-off-by: Martino Facchin <m.facchin@arduino.cc> Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
Will complete the supported peripheral list and description later Signed-off-by: Martino Facchin <m.facchin@arduino.cc>
|
@nordicjm please revisit, thanks! 🙇 |
@nordicjm As already mentioned last week, I need precise ordering between the above devices:
I see no way to achieve this without a |
FYI @nashif |
As per title, this PR is a WIP for Arduino Portenta C33 support.
The porting status is quite advanced but it's still missing a couple of very important features.
Based on RA6M5 microcontroller, onboard peripherals that need to be supported are:
https://builds.zephyrproject.io/zephyr/pr/85337/docs/boards/arduino/portenta_c33/doc/index.html