boards: Add support WizNet W5500 EVB Pico2 #84834

soburi · 2025-01-28T21:52:06Z

Add initial support for W5500 EVB Pico2

~~note:~~

I am aware that the tests/net/conn_mgr_monitor/net.conn_mgr.dad test will fail if the netif:eth function support is explicitly stated in yaml, but I will submit it following the settings of w5500_evb_pico, which only differs in soc.

~~#85816~~

kartben · 2025-01-28T22:24:51Z

boards/wiznet/w5500_evb_pico2/doc/index.rst

+.. _w5500_evb_pico2:
+
+Wiznet W5500 Evaluation Pico
+############################


Suggested change

.. _w5500_evb_pico2:

Wiznet W5500 Evaluation Pico

############################

.. zephyr:board:: w5500_evb_pico2

kartben · 2025-01-28T22:25:18Z

boards/wiznet/w5500_evb_pico2/doc/index.rst

+
+.. figure:: img/w5500_evb_pico2_side.png
+     :align: center
+     :alt: W5500 Evaluation Board
+
+     Wiznet W5500_EVB_PICO evaluation board (Image courtesy of Wiznet)


Suggested change

.. figure:: img/w5500_evb_pico2_side.png

:align: center

:alt: W5500 Evaluation Board

Wiznet W5500_EVB_PICO evaluation board (Image courtesy of Wiznet)

kartben · 2025-01-28T22:31:07Z

boards/wiznet/w5500_evb_pico2/doc/index.rst

+Pin Mapping
+===========
+
+The peripherals of the RP2040 SoC can be routed to various pins on the board.


RP2040? 🤔

kartben · 2025-01-28T22:34:06Z

boards/wiznet/w5500_evb_pico2/doc/index.rst

+Overview
+********
+
+W5500-EVB-Pico is a microcontroller evaluation board based on the Raspberry


Pico --> Pico2? Looks like you need to do a global pass just like with RP2040 vs RP2350

Ah, this is still draft...
I haven't written the documentation yet.
I plan to update it based on rp2040.

Sorry didn't notice it was in draft, my bad!

Don't mind. Thank you for caring.

I have made some general revisions and removed the draft. Please review it again.

boards/wiznet/w5500_evb_pico2/Kconfig.defconfig

nordicjm · 2025-01-29T11:23:03Z

boards/wiznet/w5500_evb_pico2/doc/index.rst

+Supported Features
+==================
+
+The w5500_evb_pico2 board configuration supports the following


Suggested change

The w5500_evb_pico2 board configuration supports the following

The ``w5500_evb_pico2`` board supports the following

boards/wiznet/w5500_evb_pico2/w5500_evb_pico2.dtsi

soburi · 2025-02-03T14:20:42Z

@raveious

If you know or can try it, could you let me know whether the tests/net/conn_mgr_monitor/net.conn_mgr.dad test passes on the w5500_evb_pico device?

When I tried to check the operation of w5500_evb_pico2, I ran the test using the following command, but it failed. So, I would like to know the result on w5500_evb_pico.

west twister --device-testing --device-serial /dev/ttyACM0 -p w5500_evb_pico2/rp2350a/m33 -s tests/net/conn_mgr_monitor/net.conn_mgr.dad -xOPENOCD=/usr/local/bin/openocd

zephyrbot · 2025-02-05T22:59:31Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

raveious · 2025-02-08T14:15:56Z

@raveious

If you know or can try it, could you let me know whether the tests/net/conn_mgr_monitor/net.conn_mgr.dad test passes on the w5500_evb_pico device?

When I tried to check the operation of w5500_evb_pico2, I ran the test using the following command, but it failed. So, I would like to know the result on w5500_evb_pico.
west twister --device-testing --device-serial /dev/ttyACM0 -p w5500_evb_pico2/rp2350a/m33 -s tests/net/conn_mgr_monitor/net.conn_mgr.dad -xOPENOCD=/usr/local/bin/openocd

The suite is filtered out for the w5500_evb_pico target, so to "technically' runs successfully.

soburi · 2025-02-11T21:15:58Z

@raveious
If you know or can try it, could you let me know whether the tests/net/conn_mgr_monitor/net.conn_mgr.dad test passes on the w5500_evb_pico device?
When I tried to check the operation of w5500_evb_pico2, I ran the test using the following command, but it failed. So, I would like to know the result on w5500_evb_pico.
west twister --device-testing --device-serial /dev/ttyACM0 -p w5500_evb_pico2/rp2350a/m33 -s tests/net/conn_mgr_monitor/net.conn_mgr.dad -xOPENOCD=/usr/local/bin/openocd
The suite is filtered out for the w5500_evb_pico target, so to "technically' runs successfully.

Thank you for the information. I understand the background. However, It is seems we need to consideration...

soburi · 2025-03-08T00:47:14Z

@kartben @nordicjm @raveious
I have made some general revisions and removed the draft. Please review it again.

raveious · 2025-03-08T01:49:37Z

boards/wiznet/w5500_evb_pico2/doc/img/w5500_evb_pico2_side.png

I could be wrong, but I think the silk screen says "W5500 EVB PICO" on it.

Oh, It's a terrible mistake...
Thank you for catching it.
I fetched the correct image and replaced it from https://docs.wiznet.io/Product/iEthernet/W5500/w5500-evb-pico2.

raveious · 2025-03-08T01:50:45Z

boards/wiznet/w5500_evb_pico2/support/openocd.cfg

@@ -0,0 +1,11 @@
+# Copyright (c) 2024 TOKITA Hiroshi


Thanks for your pointing out.
Fixed it.

kartben · 2025-03-08T02:29:33Z

boards/wiznet/w5500_evb_pico2/board.yml

@@ -0,0 +1,6 @@
+board:
+  name: w5500_evb_pico2
+  full_name: W5500 Evaluation Pico2


W5500-EVB-Pico2

Same mistake was made for the Pico-based board -- this should be the commercial name

kartben · 2025-03-08T02:31:53Z

boards/wiznet/w5500_evb_pico2/doc/index.rst

+Wiznet W5500 Evaluation Board Pico2
+###################################
+


Suggested change

Wiznet W5500 Evaluation Board Pico2

###################################

kartben · 2025-03-08T02:32:27Z

boards/wiznet/w5500_evb_pico2/doc/index.rst

+
+.. figure:: img/w5500_evb_pico2.webp
+     :align: center
+     :alt: W5500 Evaluation Board
+
+     Wiznet W5500_EVB_PICO evaluation board (Image courtesy of Wiznet)


Zephyr board sphinx directive takes care of adding the image to the overview box

Suggested change

.. figure:: img/w5500_evb_pico2.webp

:align: center

:alt: W5500 Evaluation Board

Wiznet W5500_EVB_PICO evaluation board (Image courtesy of Wiznet)

nordicjm · 2025-03-10T07:26:33Z

boards/wiznet/w5500_evb_pico2/w5500_evb_pico2-pinctrl.dtsi

+		group1 {
+			pinmux = <UART0_TX_P0>;
+		};
+		group2 {


newline needed

boards/wiznet/w5500_evb_pico2/w5500_evb_pico2-pinctrl.dtsi

boards/wiznet/w5500_evb_pico/board.yml

nordicjm · 2025-03-10T07:28:59Z

boards/wiznet/w5500_evb_pico2/w5500_evb_pico2_rp2350a_m33_defconfig

@@ -0,0 +1,11 @@
+CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=150000000


should be set in the soc Kconfig file from the dts property (can be fixed in another PR)

Moved it into Kconfig.defconfig.

Add initial support for W5500 EVB Pico2 Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

Use `W5500-EVB_Pico` - the commercial name of this board - for `full_name` field of `board.yml`. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

soburi · 2025-03-10T13:18:47Z

@raveious
Sorry, but could you check again?

raveious · 2025-03-10T13:29:14Z

@raveious Sorry, but could you check again?

Same test(s) as before? I'll take a look later tonight.

soburi · 2025-03-10T13:41:08Z

@raveious Sorry, but could you check again?

Same test(s) as before? I'll take a look later tonight.

The tests that were failing before now work correctly with the fix in #85816.
Your Change Request was still open, so I'd like you to check if there are any problems.
Thank you.

soburi mentioned this pull request Jan 28, 2025

TaskList for Supporting RaspberryPi Pico peripherals #53810

Open

55 tasks

soburi added the platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) label Jan 28, 2025

kartben requested changes Jan 28, 2025

View reviewed changes

nordicjm reviewed Jan 29, 2025

View reviewed changes

soburi force-pushed the w5500_evb_pico2 branch from 80727a3 to e4de44b Compare February 5, 2025 22:58

soburi added the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Feb 5, 2025

zephyrbot added manifest manifest-hal_rpi_pico labels Feb 5, 2025

soburi force-pushed the w5500_evb_pico2 branch 2 times, most recently from 7d574bc to ec6f320 Compare February 11, 2025 21:32

zephyrbot removed manifest manifest-hal_rpi_pico DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Feb 11, 2025

soburi force-pushed the w5500_evb_pico2 branch from ec6f320 to 290416e Compare February 15, 2025 05:52

soburi mentioned this pull request Feb 15, 2025

tests: tests/net/conn_mgr_monitor/net.conn_mgr.dad failed with W5500 #85816

Closed

soburi force-pushed the w5500_evb_pico2 branch 2 times, most recently from da089f4 to 87c9c53 Compare February 19, 2025 23:24

soburi force-pushed the w5500_evb_pico2 branch 3 times, most recently from 53b3ede to 286ac1e Compare March 7, 2025 23:51

soburi changed the title ~~boards: Add suupport WizNet W5500 EVB Pico2~~ boards: Add support WizNet W5500 EVB Pico2 Mar 7, 2025

soburi marked this pull request as ready for review March 8, 2025 00:48

soburi requested review from kartben and nordicjm March 8, 2025 00:48

zephyrbot added the area: ADC Analog-to-Digital Converter (ADC) label Mar 8, 2025

zephyrbot requested a review from anangl March 8, 2025 00:49

zephyrbot assigned anangl Mar 8, 2025

raveious suggested changes Mar 8, 2025

View reviewed changes

soburi force-pushed the w5500_evb_pico2 branch 3 times, most recently from 6e331c2 to 35c8f10 Compare March 8, 2025 02:25

kartben requested changes Mar 8, 2025

View reviewed changes

soburi force-pushed the w5500_evb_pico2 branch from 35c8f10 to 2564540 Compare March 8, 2025 03:01

kartben previously approved these changes Mar 8, 2025

View reviewed changes

nordicjm reviewed Mar 10, 2025

View reviewed changes

soburi added 2 commits March 10, 2025 18:09

boards: Add support WizNet W5500 EVB Pico2

cb1bdf1

Add initial support for W5500 EVB Pico2 Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

doc: boards: wiznet: Use product name for full_name in board.yml

40a0ac7

Use `W5500-EVB_Pico` - the commercial name of this board - for `full_name` field of `board.yml`. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

soburi dismissed kartben’s stale review via 40a0ac7 March 10, 2025 09:10

soburi force-pushed the w5500_evb_pico2 branch from 2564540 to 40a0ac7 Compare March 10, 2025 09:10

soburi requested review from nordicjm, raveious and kartben March 10, 2025 09:19

kartben approved these changes Mar 10, 2025

View reviewed changes

anangl approved these changes Mar 10, 2025

View reviewed changes

raveious approved these changes Mar 10, 2025

View reviewed changes

kartben assigned soburi Mar 10, 2025

nordicjm approved these changes Mar 11, 2025

View reviewed changes

kartben merged commit 5b28a82 into zephyrproject-rtos:main Mar 12, 2025
17 checks passed

soburi deleted the w5500_evb_pico2 branch March 12, 2025 15:01

	The w5500_evb_pico2 board configuration supports the following
	The ``w5500_evb_pico2`` board supports the following

		Wiznet W5500 Evaluation Board Pico2
		###################################

		@@ -0,0 +1,11 @@
		CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=150000000

boards: Add support WizNet W5500 EVB Pico2 #84834

boards: Add support WizNet W5500 EVB Pico2 #84834

Uh oh!

Conversation

soburi commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

soburi commented Feb 3, 2025

Uh oh!

zephyrbot commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raveious commented Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soburi commented Feb 11, 2025

Uh oh!

soburi commented Mar 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soburi commented Mar 10, 2025

Uh oh!

raveious commented Mar 10, 2025

Uh oh!

soburi commented Mar 10, 2025

Uh oh!

Uh oh!

Uh oh!

soburi commented Jan 28, 2025 •

edited

Loading

zephyrbot commented Feb 5, 2025 •

edited

Loading

raveious commented Feb 8, 2025 •

edited

Loading