-
Notifications
You must be signed in to change notification settings - Fork 7.6k
pico-sdk: Remove unnecessary Kconfig items #84545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
bc726e5
to
fe2b43f
Compare
- Remove unnecessary Kconfig settings. - Exclude unnecessary drivers from the build target. - Remove the include conditions and make all include targets uniform. - Change claim.c to always be compiled. These measures will delete unnecessary Kconfig items. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Reorder items to make the file easier to read. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
fe2b43f
to
c7db7c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see the first commit message reworded to clarify what's going on. As it's currently written (reading from top to bottom) it reads like this.
- The Kconfig files were unnecessary, so then I removed them.
- Then I remove the include conditions and make all include targets uniform.
But this is backwards: because you've made the includes unconditional (and, in some cases also removed some source files from being compiled), the Kconfig options became unnecessary, so could be removed.
This begs the question "is it better to unconditionally have a long list of include directories, or conditionally add them as required?" I prefer the latter, shorter command line calls to the pre-processor, clearer what file it required for what subsystem/driver.
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
These measures will delete unnecessary Kconfig items.