west.yaml: update hal_rpi_pico to be based on Pico SDK 2.1.0 #84204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Counter
platform: Raspberry Pi Pico
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_rpi_pico
DNM
nordic-krch
previously approved these changes
Jan 22, 2025
|
@ajf58 |
@ajf58 thanks for the note, but FYI this is handled automatically by the Manifest GitHub action, which will add a DNM label until the PR points to a SHA (which implies that the module PR has been merged). |
carlescufi
previously approved these changes
Jan 23, 2025
ajf58
force-pushed
the
update_rpi_pico_sdk
branch
from
e5254b5 to
2be2514
Compare
This version of the HAL is based on the 2.1.0 release of the Raspberry Pi Pico SDK. Update `modules/hal_rpi_pico/CMakeLists.txt` to add the new include directories to the build. See https://github.com/raspberrypi/pico-sdk/releases/tag/2.1.0 for more information. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com> Signed-off-by: Andrew Featherstone <andrew.featherstone@gmail.com>
Changes introduced in 293b9a1 didn't verify correct behaviour when running `TIMER1` with `TIMER0` is paused, and was reporting the wrong tick counter being incremented. Correct this and extend the testing to verify correct behaviour. Signed-off-by: Andrew Featherstone <andrew.featherstone@gmail.com>
ajf58
force-pushed
the
update_rpi_pico_sdk
branch
from
2be2514 to
7a89fd7
Compare
carlescufi
approved these changes
Jan 23, 2025
|
Latest push is a rebase off an updated |
soburi
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be merged until zephyrproject-rtos/hal_rpi_pico#8 has been approved .
Summary
hal_rpi_picoto the 2.1.0 release. This brings in a number of bugfixes and improvements.rpi_pico_timer. Updating the HAL to use a newer version of the SDK brings in a bugfix in the SDK, which in turn exposes a bug in therpi_pico_timer. Fix the bug and extend the test coverage to confirm and verify this.This PR supersedes #82680
Testing
Locally tested against the Raspberry Pico 2, with no regressions identified. Build-only testing for a couple of RP2040-based boards with no issues found.
Fixes #82452