video: samples: i.MX RT10xx: Do not use PxP to flip images #82672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to mirror the video image horizontally. This helps to avoid doing so at the post-processing step by using additional HW such as PxP on i.MX RT platforms. Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
Do hflipping at camera level to avoid using PxP which impacts camera framerates on RT10xx. Moreover, on RT11xx, PxP is already reserved for 90 CCW image rotation. Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
|
Hi @DerekSnell, could you take a look to see whether this is better and still preserve your goal on mt9m114 ? |
DerekSnell
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Thanks @ngphibang ,
This works great for me. I tested with your patches applied to #81830, using the command below:
west build -b mimxrt1060_evkb --shield=rk043fn66hs_ctg --shield=dvp_fpc24_mt9m114 samples/drivers/video/capture
|
This is ready as #81830 got merged. |
josuah
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On RT10xx, do horizontal flipping at camera level to avoid using PxP which impacts camera framerates. Moreover, on RT11xx, PxP is already reserved for 90 CCW image rotation for LCD display purpose.
This will work on mt9m114 only when #81830 is merged.