-
Notifications
You must be signed in to change notification settings - Fork 7.6k
drivers: serial: pl011: Add fifo enable configuration #79474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
@@ -94,6 +94,7 @@ | |||
status = "okay"; | |||
pinctrl-0 = <&uart0_default>; | |||
pinctrl-names = "default"; | |||
fifo-enable; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to have fifo-enable;
defined in every board?
Perhaps it would be better to define it once in the SoC DeviceTree and use /delete-property/ fifo-enable;
where it should be disabled. Or have fifo-disable;
option instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, under the dts folder prefer "vanilla settings".
There are other devices with fifo-enable
settings, but most are set under boards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see fifo-enable
is only set in a few overlays for stm devices.
it81xx2 sets is on some peripheral instances but as far as I understand this is to explicitly allocate which i2c instance (out of 4) gets to use the fifo channels (out of 2).
This features does not seem to have significant drawbacks so is there any reason for not enabling it by default and let boards/projects set fifo-disable
if they explicitly don't want it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From that perspective, I am simply following the precedent set by the STM32.
There is no problem with changing it to fifo-disable
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the change in the direction you suggested.
In this case, the default behavior does not change, so there is no need to change the settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xudongzheng @ithinuel I changed it to fifo-disable
. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think fifo-disable
makes more sense especially since it wouldn't change the existing behavior on out-of-tree boards.
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
6aa5fb0
to
c1fb7dd
Compare
0457bb4
to
dadbc92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit message says "configuraition" rather than "configuration"
52844ff
to
09eae3c
Compare
c4e813c
09eae3c
to
c4e813c
Compare
rebased. |
@carlocaione |
Add a setting to the devicetree for disabling the PL011 FIFO. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
c4e813c
to
02929c3
Compare
@carlocaione @ithinuel @RichardSWheatley @AlessandroLuo Could you take a look if you have a bit of a while? |
Add a setting to the devicetree for enabling or disabling
the PL011 FIFO.
fix #74914