-
Notifications
You must be signed in to change notification settings - Fork 7.6k
lib: cpp: Introduce FULL_LIBCPP_SUPPORTED similar to C version #57445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
plan to use this for thrift samples to start. |
In true FB fashion, there is yet another thrift that has been open-sourced. https://github.com/facebook/fbthrift This one seems like it would be significantly less resource intensive because it uses std::coroutine and std::string_view. I would love to put together an ISO C code generator on the other hand.. Apache Thrift relies on glib unfortunately |
Would be good to see this in actual use to make sure it works as advertised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are adding FULL_LIBCPP_SUPPORTED
, shall we add MINIMAL_LIBCPP_SUPPORTED
, GLIBCXX_LIBCPP_SUPPORTED
and others as well?
I figured we would add them if they where needed. |
Here's how this would be used: |
@stephanosio do you think we should add |
No, because
No, because this option is intended to be selected when an external standard C++ library is used (e.g. when user/application supplies their own standard C++ library). So, I would say we should leave the selection of the In case of the Lines 317 to 319 in 58088f3
|
Introduce Kconfig symbol FULL_LIBCPP_SUPPORTED that is similar to the C version FULL_LIBC_SUPPORTED. This way we can utilize the same pattern in tests and samples to filter for when a full libc++ is needed. Signed-off-by: Kumar Gala <kumar.gala@intel.com>
Introduce Kconfig symbol FULL_LIBCPP_SUPPORTED that is similar to the C version FULL_LIBC_SUPPORTED. This way we can utilize the same pattern in tests and samples to filter for when a full libc++ is needed.