-
Notifications
You must be signed in to change notification settings - Fork 7.6k
soc: arm: rpi_pico: Add support for binary info feature #54290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
463304d
to
93e30d2
Compare
binary info
featurecdbad46
to
71495bb
Compare
71495bb
to
25a1cc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work!
I am not sure about the CMake variable changes here. I'd like @tejlmand to confirm it is OK.
Before I comment on the changes themselves - I think this feature would be beneficial for all Zephyr users, not only for the pico. Being able to embed strings in a binary where they're accessable outside of the image is very useful. The main use case I can think of is a bootloader and an app being able to read each other's versions. Since this would require some more work I'm not sure it should block this PR for the meantime, but that is something to keep in mind. |
d0736a3
to
480ff02
Compare
The 'self-reference'-ish feature is interresting suggestion. |
dev-review: depends on #54464 |
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
@soburi Why does this depend on #54464? |
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
1aabdb7
to
a33121a
Compare
a33121a
to
9f346fe
Compare
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
9f346fe
to
5bc38af
Compare
4d11b36
to
3478ed8
Compare
Adds `DT_CHILD_BY_IDX` to get the child elements of a node by index. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
The binary info feature references `boot_stage2` and `pico_binary_info`. Add these to include dirs. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Use the definition of PICO_NO_BINARY_INFO if it already exists, set it as 1 if not so. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Enable embedding binary info to flash. As a default, information collects from the build configuration. It can override by the Kconfig configurations, such as ``` CONFIG_RP2_BINARY_INFO_PROGRAM_NAME_OVERRIDE=y CONFIG_RP2_BINARY_INFO_PROGRAM_NAME="my program name" ``` Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
3478ed8
to
928f18f
Compare
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
Enable embedding binary info to flash.
As a default, information collects from the build configuration.
It can override by the Kconfig configurations, such as
Signed-off-by: TOKITA Hiroshi tokita.hiroshi@gmail.com
This PR support basic feature of pico's binary info.
It works with picotool (https://github.com/raspberrypi/picotool) to show configuration information.
(by
picotool show -a
)Other feature supporting is not yet.