crosstool-ng: Pull in the missing patches for 1.27 #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add back the patches from zephyr-crosstool-ng-1.25.0 that were missed while porting to crosstool-ng 1.27.0. In particular, "gdb: Add CT_GDB_CROSS_STATIC_LIBSTDCXX configuration" is absolutely critical in making the GDB executable self-contained on all host systems and usable on Windows. Also note that the "gdb: Refactor cross GDB build step" patch initially ported by Anas is reverted because it messed up the file indentation by mixing spaces and tabs -- I have done another iteration of this with the correct indentation in this series. "cross-gdb: Add LZMA support configuration " and "cross-gdb: Add Guile scripting support configuration" are ported as well because they are still relevant and useful. These will be eventually upstreamed. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
|
DNM until zephyrproject-rtos/crosstool-ng#38 is merged |
stephanosio
commented
Jul 22, 2025
There was a problem hiding this comment.
Verified that the Linux GDB executable no longer links against shared libgcc and libstdc++ after this change:
$ ldd aarch64-zephyr-elf-gdb
linux-vdso.so.1 (0x00007a3c7628e000)
libncursesw.so.6 => /lib/x86_64-linux-gnu/libncursesw.so.6 (0x00007a3c76220000)
libtinfo.so.6 => /lib/x86_64-linux-gnu/libtinfo.so.6 (0x00007a3c761e8000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007a3c761e3000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007a3c75509000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007a3c761de000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007a3c75200000)
/lib64/ld-linux-x86-64.so.2 (0x00007a3c76290000)
stephanosio
merged commit 9b54b7f
into
zephyrproject-rtos:main
128 of 130 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back the patches from zephyr-crosstool-ng-1.25.0 that were missed while porting to crosstool-ng 1.27.0.
In particular, "gdb: Add CT_GDB_CROSS_STATIC_LIBSTDCXX configuration" is absolutely critical in making the GDB executable self-contained on all host systems and usable on Windows.
Also note that the "gdb: Refactor cross GDB build step" patch initially ported by Anas is reverted because it messed up the file indentation by mixing spaces and tabs -- I have done another iteration of this with the correct indentation in this series.
"cross-gdb: Add LZMA support configuration " and "cross-gdb: Add Guile scripting support configuration" are ported as well because they are still relevant and useful. These will be eventually upstreamed.
crosstool-ng PR: zephyrproject-rtos/crosstool-ng#38
Fixes #972