Skip to content

boot: zephyr: boards: Assign boot_partition to code-patition #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

boot: zephyr: boards: Assign boot_partition to code-patition #128

wants to merge 1 commit into from

Conversation

jlbwoods
Copy link

@jlbwoods jlbwoods commented May 28, 2025 •
edited
Loading 

Use the boot_partition as the code-partition for RPI Pico W in order for
SysBuild to use the correct partition during the build process.

nordicjm
nordicjm requested changes May 29, 2025
View reviewed changes
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't really make any sense, the board in zephyr should be doing this

@jlbwoods
Copy link
Author

this doesn't really make any sense, the board in zephyr should be doing this

Since the board in Zephyr default to "storage" partitions, it is necessary to include "sysbuild" partitions in MCUboot. Details for this PR:

  • Delete code_partition and storage_partition provided by the default board config from the "storage" partitions
  • Include the 2M SysBuild partitions from the DTS
  • "Choose" to use the boot_partition in SysBuild partitions for the code-partition

@jlbwoods jlbwoods requested a review from nordicjm May 29, 2025 22:02
@nordicjm
Copy link
Collaborator

nordicjm commented Jun 2, 2025

this doesn't really make any sense, the board in zephyr should be doing this

Since the board in Zephyr default to "storage" partitions, it is necessary to include "sysbuild" partitions in MCUboot. Details for this PR:

* Delete `code_partition` and `storage_partition` provided by the default board config from the "storage" partitions

* Include the 2M SysBuild partitions from the DTS

* "Choose" to use the `boot_partition` in SysBuild partitions for the `code-partition`

The default partition in zephyr should have both storage and mcuboot partitions, like other boards, there should be no specific overlays in mcuboot (which wouldn't work anyway because it needs the same as the app which would use the zephyr one)

@jlbwoods
Copy link
Author

jlbwoods commented Jun 2, 2025

this doesn't really make any sense, the board in zephyr should be doing this

Since the board in Zephyr default to "storage" partitions, it is necessary to include "sysbuild" partitions in MCUboot. Details for this PR:

* Delete `code_partition` and `storage_partition` provided by the default board config from the "storage" partitions

* Include the 2M SysBuild partitions from the DTS

* "Choose" to use the `boot_partition` in SysBuild partitions for the `code-partition`

The default partition in zephyr should have both storage and mcuboot partitions, like other boards, there should be no specific overlays in mcuboot (which wouldn't work anyway because it needs the same as the app which would use the zephyr one)

The original intent is to have default boards for RPI have max storage space without the boot partitions. With this setup, we will need a specific overlay in mcuboot AND explicit use of sysbuild partition in the app.

It is more user friendly to use sysbuild partitions like what other boards are doing right now. In order to make this change, we will have to set the default partitions to use the sysbuild one with this PR: zephyrproject-rtos/zephyr#90964

@jlbwoods jlbwoods force-pushed the pr_boot_zephyr_boards branch 3 times, most recently from 21c8f26 to 2aea790 Compare June 2, 2025 17:19
jlbwoods added a commit to jlbwoods/zephyr that referenced this pull request Jun 2, 2025
@jlbwoods
dts: vendor: raspberrypi: Default to sysbuild partitions
0bdac63 
Switch the default partitions for raspberrypi to use the sysbuild
partitions in order to be consistent with the default partitions for
other vendor defined partitions.

Please refer to this PR for comments relating to this modification:
 - zephyrproject-rtos/mcuboot#128

Signed-off-by: John Lin <john.lin@beechwoods.com>
@jlbwoods jlbwoods mentioned this pull request Jun 2, 2025
Closed
jlbwoods added a commit to jlbwoods/zephyr that referenced this pull request Jun 2, 2025
@jlbwoods
dts: vendor: raspberrypi: Default to sysbuild partitions
6489599 
Switch the default partitions for raspberrypi to use the sysbuild
partitions in order to be consistent with the default partitions for
other vendor defined partitions.

Please refer to this PR for comments relating to this modification:
 - zephyrproject-rtos/mcuboot#128

Signed-off-by: John Lin <john.lin@beechwoods.com>
@jlbwoods jlbwoods force-pushed the pr_boot_zephyr_boards branch 2 times, most recently from 079f623 to fcde3f6 Compare June 2, 2025 22:08
@jlbwoods jlbwoods changed the title boot: zephyr: boards: Include default partitions boot: zephyr: boards: Assign boot_partition to code-patition Jun 2, 2025
de-nordic
de-nordic requested changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with this pr, there are some unrelated commits.

@jlbwoods
boot: zephyr: boards: Assign boot_partition to code-patition
2b6a8d3 
Use the boot_partition as the code-partition for RPI Pico W in order for
SysBuild to use the correct partition during the build process.

Signed-off-by: John Lin <john.lin@beechwoods.com>
@jlbwoods jlbwoods force-pushed the pr_boot_zephyr_boards branch from fcde3f6 to 2b6a8d3 Compare June 3, 2025 15:54
@jlbwoods
Copy link
Author

jlbwoods commented Jun 3, 2025

Something is wrong with this pr, there are some unrelated commits.

Sorry about that! Fixed it now! (I did not use the main branch as a base to create this PR.)

@jlbwoods jlbwoods requested a review from de-nordic June 3, 2025 15:56
jlbwoods added a commit to jlbwoods/zephyr that referenced this pull request Jun 3, 2025
@jlbwoods
dts: vendor: raspberrypi: Default to sysbuild partitions
83c4354 
Switch the default partitions for raspberrypi to use the sysbuild
partitions in order to be consistent with the default partitions for
other vendor defined partitions.

Please refer to this PR for comments relating to this modification:
 - zephyrproject-rtos/mcuboot#128

Signed-off-by: John Lin <john.lin@beechwoods.com>
@jlbwoods
Copy link
Author

jlbwoods commented Jun 4, 2025

Please help review again with updated fixes. Thanks!

@jlbwoods
Copy link
Author

jlbwoods commented Jun 9, 2025

Something is wrong with this pr, there are some unrelated commits.

Sorry about that! Fixed it now! (I did not use the main branch as a base to create this PR.)

I think I need to create PR based on the upstream-sync instead of main! I just created another PR: #129

I will close this one.

@jlbwoods jlbwoods closed this Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d3zd3z d3zd3z Awaiting requested review from d3zd3z

@nordicjm nordicjm Awaiting requested review from nordicjm nordicjm is a code owner

@de-nordic de-nordic Awaiting requested review from de-nordic de-nordic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlbwoods @nordicjm @de-nordic