lib/stm32: stm32wba: radio temperature calibration activation #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwango
requested changes
Jun 9, 2025
Comment on lines
379
to
383
| #define USE_TEMPERATURE_BASED_RADIO_CALIBRATION (0) | ||
| #ifdef CONFIG_BT_STM32WBA_USE_TEMPERATURE_BASED_RADIO_CALIBRATION | ||
| #define USE_TEMPERATURE_BASED_RADIO_CALIBRATION (1) | ||
| #else | ||
| #define USE_TEMPERATURE_BASED_RADIO_CALIBRATION (0) | ||
| #endif /*CONFIG_BT_STM32_USE_TEMPERATURE_BASED_RADIO_CALIBRATION*/ |
There was a problem hiding this comment.
I see 2 issues here:
- CONFIG_BT_STM32WBA_USE_TEMPERATURE_BASED_RADIO_CALIBRATION is not defined
- All code imported from Cube should not depend from Zephyr.
One suggestion would be to modify Cube code this way:
#ifndef USE_TEMPERATURE_BASED_RADIO_CALIBRATION
#define USE_TEMPERATURE_BASED_RADIO_CALIBRATION (0)
#endif
Then, define USE_TEMPERATURE_BASED_RADIO_CALIBRATION the way it is done for HSE_VALUE below:
hal_stm32/stm32cube/CMakeLists.txt
Lines 49 to 51 in d49fb6d
Ideally, this way, change could be integrated in Cube library so we don't have to maintain this as a Zephyr fix.
Finally, don't forget to document the fix in related README file.
There was a problem hiding this comment.
Thanks for your comment, this way of working has been integrated and pushed
Add the possibility to change the activation of the temperature calibration of the radio directly from a Kconfig Signed-off-by: Romain Jayles <romain.jayles@st.com>
The temperature calibration is now activable, its activation needs to be integrated in the library. Signed-off-by: Romain Jayles <romain.jayles@st.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work on the lib/stm32 allows to activate/deactivate the calibration of the radio based on the temperature sensor.
It can be activated/deactivated by a Zephyr config