-
Notifications
You must be signed in to change notification settings - Fork 134
Add STM32MP2 support #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add STM32MP2 support #282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
Otherwise, initial commit is too large to be practically reviewed.
Would you be able to split into at least another commit which introduces the common ll part ?
Regarding the -pinctrl.dtsi, there is a change being merged, so it would be required that you generate a new batch based on #279.
Thanks!
To split commits you can have a look to #266 as example. |
Provide the stm32cube HAL and LL for the stm32mp2x series mcu Origin: ST Microelectronics License: BSD-3-Clause URL: https://github.com/STMicroelectronics/STM32CubeMP2 Commit: 1b1ff6b48df3c9b7417ac411dbd8dfd097f0bb04 Purpose: HAL and LL for stm32mp2 Maintained-by: External Signed-off-by: Youssef Zini <youssef.zini@savoirfairelinux.com>
Disable the lvds module in the stm32mp2xx HAL because it is not available. Signed-off-by: Youssef Zini <youssef.zini@savoirfairelinux.com>
1909a48
to
86c2658
Compare
Update west.yml to add the STM32MP2x SoC support in the STM32 HAL. This depends on the followin Pull Request: zephyrproject-rtos/hal_stm32#282 Signed-off-by: Youssef Zini <youssef.zini@savoirfairelinux.com>
Dismissing in order not to block PR next week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Remove the use of full assert in stm32mp2xx_hal_conf.h. As done with all other STM32 HAL drivers, this prevents build errors when compiling STM32Cube-based code in Zephyr and allows successful compilation even if assertion checks are not implemented, as the code still functions correctly without them. Signed-off-by: Youssef Zini <youssef.zini@savoirfairelinux.com>
Add CMakeLists.txt to enable support of the hal and ll files for the stm32mp2x series MCU as zephyr libraries. Signed-off-by: Youssef Zini <youssef.zini@savoirfairelinux.com>
Add the stm32mp2x to the supported soc series. Add the cortex-m33 to the zephyr compile definitions. Signed-off-by: Youssef Zini <youssef.zini@savoirfairelinux.com>
Regenerate the ll headers to include the stm32mp2xx series Signed-off-by: Youssef Zini <youssef.zini@savoirfairelinux.com>
Add the pinctrl address for stm32mp2 soc family to generate the *-pinctrl.dtsi files. Signed-off-by: Youssef Zini <youssef.zini@savoirfairelinux.com>
Add the pinctrl files for stm32mp2 soc series. These files are generated from the open pin data repository, a subset of official release STM32CubeMX 6.14.0, using the genpinctrl.py script. Origin: ST Microelectronics License: BSD-3-Clause URL: https://github.com/STMicroelectronics/STM32_open_pin_data Commit: 5e641448dc7df619ee46bb0c91796b7626005929 Purpose: *-pinctrl.dtsi for stm32mp2 Maintained-by: External Signed-off-by: Youssef Zini <youssef.zini@savoirfairelinux.com>
86c2658
to
eb3d6a2
Compare
So apparently the So I commented it to allow successful builds and mentioned it in the README as it differs from the source code. Refer to the zephyr STM32MP2 PR conversations for more details. |
Update west.yml to add the STM32MP2x SoC support in the STM32 HAL. This is done after the merge of the PR:: zephyrproject-rtos/hal_stm32#282 Signed-off-by: Youssef Zini <youssef.zini@savoirfairelinux.com>
Update west.yml to add the STM32MP2x SoC support in the STM32 HAL. This depends on the followin Pull Request: zephyrproject-rtos/hal_stm32#282 Signed-off-by: Youssef Zini <youssef.zini@savoirfairelinux.com>
Update west.yml to add the STM32MP2x SoC support in the STM32 HAL. This is done after the merge of the PR:: zephyrproject-rtos/hal_stm32#282 It now references the fix pull request of the stm32mp2 HAL: zephyrproject-rtos/hal_stm32#286 Signed-off-by: Youssef Zini <youssef.zini@savoirfairelinux.com>
Hello there, Thank you for the merge. 🎩 Youssef Zini |
Update west.yml to add the STM32MP2x SoC support in the STM32 HAL. This is done after the merge of the PRs: zephyrproject-rtos/hal_stm32#282 zephyrproject-rtos/hal_stm32#286 Signed-off-by: Youssef Zini <youssef.zini@savoirfairelinux.com>
This PR adds *-pinctrl.dtsi, HAL and LL files for the STM32MP2xx series