-
Notifications
You must be signed in to change notification settings - Fork 11
action: Handle parsing of module.yml and binary blobs #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b4a8be
to
11fe45c
Compare
fc2d3bf
to
c59caac
Compare
c529ce0
to
8a8a14d
Compare
pdgendt
reviewed
May 23, 2025
8a8a14d
to
84b7132
Compare
carlescufi
added a commit
to carlescufi/zephyr
that referenced
this pull request
May 23, 2025
Update to a revision of the manifest action that includes: zephyrproject-rtos/action-manifest#21 Also add the corresponding binary blobs labels parameters to the workflow. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
0529bb1
to
0e9ca6c
Compare
This commit adds support for handling the differences inside the module.yml file in a west project update, as well as locating and displaying any changes to binary blobs. More specifically, the metadata table now displays the number of added and/or changed blobs per project, and optionall labels can be added to the Pull Request to signal reviewers that blobs have been altered. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
0e9ca6c
to
163a7ca
Compare
pdgendt
approved these changes
May 23, 2025
fabiobaltieri
approved these changes
May 23, 2025
carlescufi
added a commit
to carlescufi/zephyr
that referenced
this pull request
May 23, 2025
Update to a revision of the manifest action that includes: zephyrproject-rtos/action-manifest#21 Also add the corresponding binary blobs labels parameters to the workflow. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
carlescufi
added a commit
to carlescufi/zephyr
that referenced
this pull request
May 23, 2025
Update to a revision of the manifest action that includes: zephyrproject-rtos/action-manifest#21 Also add the corresponding binary blobs labels parameters to the workflow. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
nashif
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this pull request
May 26, 2025
Update to a revision of the manifest action that includes: zephyrproject-rtos/action-manifest#21 Also add the corresponding binary blobs labels parameters to the workflow. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Late to the game... on PTO... but this looks perfect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in zephyrproject-rtos/zephyr-testing#291