Skip to content

action: Handle parsing of module.yml and binary blobs #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

carlescufi
Copy link
Member

@carlescufi carlescufi commented May 14, 2025

This commit adds support for handling the differences inside the
module.yml file in a west project update, as well as locating and
displaying any changes to binary blobs.
More specifically, the metadata table now displays the number of added
and/or changed blobs per project, and optionall labels can be added to
the Pull Request to signal reviewers that blobs have been altered.

Tested in zephyrproject-rtos/zephyr-testing#291

image image

@carlescufi carlescufi changed the title action: Add a label whenever binary blobs are added WIP: action: Add a label whenever binary blobs are added May 14, 2025
@carlescufi carlescufi force-pushed the bin-blob-label branch 29 times, most recently from 4b4a8be to 11fe45c Compare May 22, 2025 16:20
@carlescufi carlescufi force-pushed the bin-blob-label branch 7 times, most recently from fc2d3bf to c59caac Compare May 22, 2025 17:13
@carlescufi carlescufi changed the title WIP: action: Add a label whenever binary blobs are added action: Handle parsing of module.yml and binary blobs May 22, 2025
@carlescufi carlescufi force-pushed the bin-blob-label branch 2 times, most recently from c529ce0 to 8a8a14d Compare May 22, 2025 17:23
carlescufi added a commit to carlescufi/zephyr that referenced this pull request May 23, 2025
Update to a revision of the manifest action that includes:
zephyrproject-rtos/action-manifest#21

Also add the corresponding binary blobs labels parameters to the
workflow.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
@carlescufi carlescufi force-pushed the bin-blob-label branch 2 times, most recently from 0529bb1 to 0e9ca6c Compare May 23, 2025 09:51
This commit adds support for handling the differences inside the
module.yml file in a west project update, as well as locating and
displaying any changes to binary blobs.
More specifically, the metadata table now displays the number of added
and/or changed blobs per project, and optionall labels can be added to
the Pull Request to signal reviewers that blobs have been altered.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
@carlescufi carlescufi merged commit d08f41d into zephyrproject-rtos:main May 23, 2025
carlescufi added a commit to carlescufi/zephyr that referenced this pull request May 23, 2025
Update to a revision of the manifest action that includes:
zephyrproject-rtos/action-manifest#21

Also add the corresponding binary blobs labels parameters to the
workflow.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
carlescufi added a commit to carlescufi/zephyr that referenced this pull request May 23, 2025
Update to a revision of the manifest action that includes:
zephyrproject-rtos/action-manifest#21

Also add the corresponding binary blobs labels parameters to the
workflow.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
nashif pushed a commit to zephyrproject-rtos/zephyr that referenced this pull request May 26, 2025
Update to a revision of the manifest action that includes:
zephyrproject-rtos/action-manifest#21

Also add the corresponding binary blobs labels parameters to the
workflow.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
@dleach02
Copy link
Member

Late to the game... on PTO... but this looks perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants