Check that all new revisions exist in the repo and also show matching tags #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `maybe_sha()` function was too fragile. Instead, require full, 40-byte SHAs when specifying revisions as a commit SHA. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
carlescufi
force-pushed
the
check-all-revs
branch
2 times, most recently
from
d841d76 to
3f35031
Compare
carlescufi
force-pushed
the
check-all-revs
branch
4 times, most recently
from
9eec993 to
4ca731a
Compare
carlescufi
changed the title
carlescufi
changed the title
gmarull
approved these changes
Dec 19, 2024
pdgendt
reviewed
Dec 20, 2024
Instead of only optionally checking for impostor commits, verify the validity (i.e. existence) of a particular revision by checking if it's present on any of the repo's branches or tags. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Not only branches, but tags can also point to the new SHA, and that is relevant information that should be displayed. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
carlescufi
force-pushed
the
check-all-revs
branch
from
4ca731a to
cb8f6fb
Compare
pdgendt
approved these changes
Dec 20, 2024
carlescufi
added a commit
to carlescufi/zephyr
that referenced
this pull request
Dec 20, 2024
See these PRs for additional information on what changed between v1.5.0 and v1.7.0: zephyrproject-rtos/action-manifest#15 zephyrproject-rtos/action-manifest#16 Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
carlescufi
added a commit
to carlescufi/sdk-nrf
that referenced
this pull request
Dec 20, 2024
See the following PR for more info on what changed since v1.6.0: zephyrproject-rtos/action-manifest#16 Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
carlescufi
added a commit
to nrfconnect/sdk-nrf
that referenced
this pull request
Dec 20, 2024
See the following PR for more info on what changed since v1.6.0: zephyrproject-rtos/action-manifest#16 Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
kartben
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this pull request
Dec 20, 2024
See these PRs for additional information on what changed between v1.5.0 and v1.7.0: zephyrproject-rtos/action-manifest#15 zephyrproject-rtos/action-manifest#16 Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
coreboot-bot
pushed a commit
to coreboot/zephyr-cros
that referenced
this pull request
Dec 23, 2024
See these PRs for additional information on what changed between v1.5.0 and v1.7.0: zephyrproject-rtos/action-manifest#15 zephyrproject-rtos/action-manifest#16 (cherry picked from commit 6e92a3f) Original-Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no> GitOrigin-RevId: 6e92a3f Cr-Build-Id: 8727764308049365969 Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8727764308049365969 Copybot-Job-Name: zephyr-main-copybot-downstream Change-Id: If75a1f0ede2bbd6fee7ce89bdd7647eded5e7e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/6116712 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Devansh0210
pushed a commit
to Devansh0210/zephyr
that referenced
this pull request
Jan 7, 2025
See these PRs for additional information on what changed between v1.5.0 and v1.7.0: zephyrproject-rtos/action-manifest#15 zephyrproject-rtos/action-manifest#16 Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested here: zephyrproject-rtos/zephyr-testing#291
Sample output: