-
Notifications
You must be signed in to change notification settings - Fork 11
action: Allow the user to set the west manifest import flag #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tested here: zephyrproject-rtos/zephyr-testing#291 |
In some cases, when using checked out trees to construct the manifest objects, it is important for users to be able to select which projects are imported, because they may have import statements in their manifests that they may want to honour or not. This commit allows the action user to select between import all projects (the default), none or only the projects in the self: section of the manifest. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
fd2bc30
to
0a48905
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an expert here, but LGTM
Self-merging since this is an addition that is not currently required for upstream Zephyr itself, but for other projects using this action with |
See these PRs for additional information on what changed between v1.5.0 and v1.7.0: zephyrproject-rtos/action-manifest#15 zephyrproject-rtos/action-manifest#16 Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
See these PRs for additional information on what changed between v1.5.0 and v1.7.0: zephyrproject-rtos/action-manifest#15 zephyrproject-rtos/action-manifest#16 Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
See these PRs for additional information on what changed between v1.5.0 and v1.7.0: zephyrproject-rtos/action-manifest#15 zephyrproject-rtos/action-manifest#16 (cherry picked from commit 6e92a3f) Original-Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no> GitOrigin-RevId: 6e92a3f Cr-Build-Id: 8727764308049365969 Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8727764308049365969 Copybot-Job-Name: zephyr-main-copybot-downstream Change-Id: If75a1f0ede2bbd6fee7ce89bdd7647eded5e7e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/6116712 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
See these PRs for additional information on what changed between v1.5.0 and v1.7.0: zephyrproject-rtos/action-manifest#15 zephyrproject-rtos/action-manifest#16 Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
In some cases, when using checked out trees to construct the manifest objects, it is important for users to be able to select which projects are imported, because they may have import statements in their manifests that they may want to honour or not.
This commit allows the action user to select between import all projects (the default), none or only the projects in the self: section of the manifest.