Skip to content

Update i18n requirements #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update i18n requirements #379

wants to merge 3 commits into from

Conversation

aurelieverrot
Copy link

@aurelieverrot aurelieverrot commented Jun 9, 2025 •
edited
Loading

/cc @zendesk/wattle

Description

This repo is out of date with the i18n requirements for a repo to be in the String Sweep.
This PR adds:

  • localization team is now co-owners of the translation files, so any changes to these files trigger a review request for the team prior to hitting the String Sweep
  • i18n validations in CI, to avoid sending issues to String Sweep and block the process.

References

Link to a JIRA or GitHub issue here if relevant: N/A

Before merging this PR

  • Fill out the Risks section
  • Think about performance and security issues

Risks

  • [RUNTIME] This does not affect any code logic
  • [low] No features are impacted, these are preventive measures to avoid issues with the l10n/i18n process.

@aurelieverrot aurelieverrot requested a review from a team as a code owner June 9, 2025 10:34
@aurelieverrot aurelieverrot force-pushed the aurelie/i18n-requirements branch from 33f58ae to aacb18e Compare June 9, 2025 10:46
@aurelieverrot
Copy link
Author

Nevermind, the repo is public, so we won't do the i18n validations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aurelieverrot