Skip to content

Skip vendored gem files #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Skip vendored gem files #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7de4850
Skips files in vendor
kjeldahl May 19, 2022
42101b6
Adds dummy bundled gem file
kjeldahl May 19, 2022
2260f83
Updates spec for files
kjeldahl May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/zendesk_apps_support/package.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def files
Dir[root.join('**/**')].each do |f|
next unless File.file?(f)
relative_file_name = f.sub(%r{#{root}/?}, '')
next if relative_file_name =~ %r{^tmp/}
next if relative_file_name =~ %r{^(tmp|vendor)/}
files << AppFile.new(self, relative_file_name)
end
files
Expand Down
1 change: 1 addition & 0 deletions spec/app/vendor/bundle/bundled_gem.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# An example of a vendor bundled gem file
2 changes: 1 addition & 1 deletion spec/package_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
end

describe 'files' do
it 'should return all the files within the app folder excluding files in tmp folder' do
it 'should return all the files within the app folder excluding files in tmp and vendor folder' do
files = %w[app.css app.js assets/logo-small.png assets/logo.png lib/a.js lib/a.txt
lib/nested/b.js manifest.json templates/layout.hdbs translations/en.json translations/nl.json]
expect(@package.files.map(&:relative_path)).to match_array(files)
Expand Down