[DINGO-1663] Remove all references to targets from ZAS

lib/zendesk_apps_support/app_requirement.rb

@@ -6,7 +6,7 @@ class AppRequirement
     CUSTOM_OBJECTS_KEY = 'custom_objects'
     CUSTOM_OBJECTS_TYPE_KEY = 'custom_object_types'
     CUSTOM_OBJECTS_RELATIONSHIP_TYPE_KEY = 'custom_object_relationship_types'
-    TYPES = %w[automations channel_integrations custom_objects macros targets views ticket_fields
+    TYPES = %w[automations channel_integrations custom_objects macros views ticket_fields
                triggers user_fields organization_fields webhooks].freeze
   end
 end

spec/bookmarks_app/requirements.json

@@ -1,10 +1,17 @@
 {
-  "targets": {
-    "jira_story_target": {
-      "title": "blah",
-      "type": "jira_target",
-      "active": true,
-      "target_url": "http://example.org"
+  "webhooks": {
+    "new_webhook_1": {
+      "endpoint": "https://webhook.site/81a0f086-7a95-4654-b224-534c3a5bd319",
+      "http_method": "GET",
+      "name": "App Created Webhook 1",
+      "title": "my webhook",
+      "description": "Webhook for my really sweet app",
+      "request_format": "json",
+      "status": "active",
+      "signing_secret": {
+        "secret": "pvXR0btAdXdFazX8TPRqbGHZJFGmUs6pqAIKR46REk0",
+        "algorithm": "SHA256"
+      }
     }
   },
 

spec/validations/fixture/requirements.json

@@ -1,10 +1,17 @@
 {
-  "targets": {
-    "jira_story_target": {
-      "title": "blah",
-      "type": "jira_target",
-      "active": true,
-      "target_url": "http://example.org"
+  "webhooks": {
+    "new_webhook_1": {
+      "endpoint": "https://webhook.site/81a0f086-7a95-4654-b224-534c3a5bd319",
+      "http_method": "GET",
+      "name": "App Created Webhook 1",
+      "title": "my webhook",
+      "description": "Webhook for my really sweet app",
+      "request_format": "json",
+      "status": "active",
+      "signing_secret": {
+        "secret": "pvXR0btAdXdFazX8TPRqbGHZJFGmUs6pqAIKR46REk0",
+        "algorithm": "SHA256"
+      }
     }
   },
 

spec/validations/requirements_spec.rb

@@ -111,7 +111,7 @@
   end
 
   context 'a requirement field missing a "key"' do
-    let(:requirements_string) { JSON.generate('targets' => { 'abc' => {} }) }
+    let(:requirements_string) { JSON.generate('webhooks' => { 'abc' => {} }) }
 
     it 'creates an error for missing required fields' do
       expect(errors.first.key).to eq(:missing_required_fields)
@@ -172,10 +172,10 @@
   end
 
   context 'many requirements are lacking required fields' do
-    let(:requirements_string) { JSON.generate('targets' => { 'abc' => {}, 'xyz' => {} }) }
+    let(:requirements_string) { JSON.generate('webhooks' => { 'abc' => {}, 'xyz' => {} }) }
 
     it 'creates an error for each of them' do
-      expect(errors.size).to eq(2)
+      expect(errors.size).to eq(10)
     end
   end
 
@@ -187,6 +187,13 @@
     end
   end
 
+  context 'there is a targets requirement type' do
+    let(:requirements_string) { JSON.generate('targets' => { 'abc' => {}, 'xyz' => {} }) }
+    it 'creates an error' do
+      expect(errors.first.key).to eq(:invalid_requirements_types)
+    end
+  end
+
   context 'there are duplicate requirements' do
     let(:requirements_string) { '{ "a": { "b": 1, "b": 2 }}' }