Skip to content

chore(whats-app-template): update response type #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 9, 2025

Conversation

tristan-vu
Copy link
Contributor

Description

update whats app response to include responseJson

How to manually test

  1. Install version x.x.x
  2. Use service ...
  3. ...

Include label

We are following this pattern to keep our package version updated. Please add the appropriate label to your Pull requests between the following:

  • Version: Major
  • Version: Minor
  • Version: Patch

Acceptation criteria

  • Added the corrected label to my pull request
  • Added/updated tests impacted by the change
  • Documentation is up-to-date (README.md / INSTALL.md)
  • Manually tested?

github-actions[bot]
github-actions bot previously approved these changes Apr 8, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤖 🚀 🔥

@github-actions github-actions bot dismissed their stale review April 8, 2025 18:47

Dismiss bot.

github-actions[bot]
github-actions bot previously approved these changes Apr 8, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤖 🚀 🔥

@github-actions github-actions bot dismissed their stale review April 8, 2025 18:49

Dismiss bot.

github-actions[bot]
github-actions bot previously approved these changes Apr 8, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤖 🚀 🔥

@github-actions github-actions bot dismissed their stale review April 8, 2025 18:55

Dismiss bot.

github-actions[bot]
github-actions bot previously approved these changes Apr 8, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤖 🚀 🔥

Copy link
Contributor

@Vico1993 Vico1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Could you also update the type ISendNotificationResponse please.

@github-actions github-actions bot dismissed their stale review April 9, 2025 14:38

Dismiss bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤖 🚀 🔥

Copy link
Contributor

@Vico1993 Vico1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@tristan-vu tristan-vu added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit d8dd02e Apr 9, 2025
8 checks passed
@tristan-vu tristan-vu deleted the update-response-type branch April 9, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants