Skip to content

feat: Add capabilities for Zendesk API service to upload bundle to a zis integration #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025

Conversation

Vico1993
Copy link
Contributor

@Vico1993 Vico1993 commented May 28, 2025

Description

This PR adds a new method uploadZisBundle to the ZendeskApiService that allows uploading a ZIS bundle to a specific integration. The method performs a POST request with the given bundle data to the appropriate ZIS registry endpoint.

Additionally, new tests were added in __tests__/services/zendesk-api-service.spec.ts to verify the behavior of the uploadZisBundle method, ensuring the request is made with the correct URL, method, content type, and data.

How to manually test

  1. Import ZendeskApiService and instantiate it.
  2. Call the uploadZisBundle method with an integration name and a bundle object.
  3. Verify that the HTTP request is sent to /api/services/zis/registry/{integrationName}/bundles using POST with JSON payload.
  4. Run the test suite to confirm the new test cases pass.

Include label

  • Version: Minor

Acceptation criteria

  • Added the corrected label to my pull request
  • Added/updated tests impacted by the change
  • Documentation is up-to-date (README.md / INSTALL.md)
  • Manually tested?

github-actions[bot]
github-actions bot previously approved these changes May 28, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤖 🚀 🔥

Base automatically changed from victor.piolin/zis-oauth to main May 30, 2025 18:45
@Vico1993 Vico1993 marked this pull request as ready for review May 30, 2025 18:46
@github-actions github-actions bot dismissed their stale review May 30, 2025 18:46

Dismiss bot.

Copy link

Bump version from 0.8.0 to 0.9.0

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤖 🚀 🔥

@Vico1993 Vico1993 requested review from tristan-vu and pol-mampey May 30, 2025 19:07
@Vico1993 Vico1993 enabled auto-merge June 2, 2025 16:58
@Vico1993 Vico1993 added this pull request to the merge queue Jun 2, 2025
Merged via the queue into main with commit b2fc33c Jun 2, 2025
@Vico1993 Vico1993 deleted the victor.piolin/zis-bundle branch June 2, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants