Skip to content

feat: Add support for Zis Connection, Zis Token and zis webhook #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2025

Conversation

Vico1993
Copy link
Contributor

Description

This PR introduces new features to the Zendesk API service integration:

  • Adds the ability to create OAuth access tokens via createZendeskAccessToken method.
  • Implements methods to create ZIS (Zendesk Integration Services) connections (createZisConnection) and inbound webhooks (createZisInboundWebhook).
  • Adds corresponding TypeScript models for the new API responses.
  • Includes comprehensive tests for these new service methods to verify correct request payloads.

These enhancements enable programmatic creation and management of access tokens, connections, and webhooks for Zendesk integrations within the service.

How to manually test

  1. Use the test suite to verify new coverage:
    npm run test __tests__/services/zendesk-api-service.spec.ts
  2. Alternatively, instantiate ZendeskApiService and call:
    • createZendeskAccessToken(clientId, scopes)
    • createZisConnection(integrationName, token, connectionName, allowedDomain)
    • createZisInboundWebhook(integrationName, token, sourceSystem, eventType)
  3. Confirm that the requests are correctly formatted and the responses match expected interface structures.

Include label

  • Version: Minor

Acceptation criteria

  • Added the corrected label to my pull request
  • Added/updated tests impacted by the change
  • Documentation is up-to-date (README.md / INSTALL.md)
  • Manually tested?

@Vico1993 Vico1993 self-assigned this May 28, 2025
github-actions[bot]
github-actions bot previously approved these changes May 28, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤖 🚀 🔥

Base automatically changed from victor.piolin/zis-jobspec to main May 30, 2025 18:40
@github-actions github-actions bot dismissed their stale review May 30, 2025 18:40

Dismiss bot.

Copy link

Bump version from 0.7.0 to 0.8.0

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤖 🚀 🔥

@Vico1993 Vico1993 marked this pull request as ready for review May 30, 2025 18:41
@Vico1993 Vico1993 added this pull request to the merge queue May 30, 2025
Merged via the queue into main with commit 0233bef May 30, 2025
@Vico1993 Vico1993 deleted the victor.piolin/zis-oauth branch May 30, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants