Skip to content

Fix lookup relationship fields (lurf) in service catalog forms #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

luis-almeida
Copy link
Contributor

Description

  1. organizationField was not passed to the TicketField component as it was marked as an "optional"
  2. The problem was that inside the TicketField component we checked if organizationField !== null when building up the API endpoint and since organizationField was undefined it resulted in broken API calls:
image

This PR addresses this issue and just passed organizationField={null} since the "organization field" is a standard field and can't be added to a Service Catalog Item form.

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

@luis-almeida luis-almeida requested a review from a team as a code owner May 2, 2025 12:54
Copy link
Contributor

@BrunoBFerreira BrunoBFerreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Are there any unit tests we could add for this?

@luis-almeida
Copy link
Contributor Author

Are there any unit tests we could add for this?

Where would you add you add it?

@BrunoBFerreira
Copy link
Contributor

Are there any unit tests we could add for this?

Where would you add you add it?

I think maybe we could check if the form is now being rendered correctly but given that now we are always passing the null value might not be an very interesting test. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants