Skip to content

Add Edit Terrain Location Module #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Add Edit Terrain Location Module #751

wants to merge 21 commits into from

Conversation

@ampersand38
Copy link
Member

@ampersand38 ampersand38 commented Oct 7, 2023 •
edited
Loading

When merged this pull request will:

@ampersand38 ampersand38 added the feature Adds a new feature label Oct 7, 2023
mharis001
mharis001 requested changes Oct 8, 2023
View reviewed changes
@mharis001 mharis001 added this to the 1.15.0 milestone Oct 8, 2023
mharis001
mharis001 reviewed Oct 8, 2023
View reviewed changes
@ampersand38 ampersand38 changed the title Add Location Module Add Edit Terrain Location Module Oct 9, 2023
mharis001
mharis001 reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some style/cleanup suggestions.

mharis001
mharis001 requested changes Jan 25, 2024
View reviewed changes
Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work for JIP.

@mharis001 mharis001 modified the milestones: 1.15.0, 1.16.0 Jul 18, 2024
@ampersand38
Copy link
Member Author

I tried to use str _location for _jipID, but couldn't get it to work. On the 2nd and further edits of a location, it would get passed to remote machines as No Location. Seems to be working with the position though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mharis001 mharis001 mharis001 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

feature Adds a new feature

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ampersand38 @mharis001