feat: set text mouse shape for text-mode panes using OSC 22 mouse shape protocol (#4173) #4174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This definitely looks cool and I can imagine lots of applicative/plugin uses for this in Zellij. That being said, I'm usually cautious implementing new protocols/escape-sequences in order not to take ownership of code and functionality that might not (ever) be adopted by the wider ecosystem. My measure is usually "did Alacritty implement and release it already?" If they will, I'd be happy to consider this. It seems though that the maintainers are a bit skeptical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4173
A picture is worth a thousand words:
Peek.2025-04-30.22-03.mp4
Support in terminals
It works at least in Kitty and xterm. I've also checked iTerm2, but it does not work there despite there is OSC 22 supporting code. I can even see "invalidateCursorRectsForView" in debug logs, which means that the OSC 22 sequence was successfully parsed, but the mouse pointer shape does not change. Probably a bug in iTerm2. In Alacritty there is a draft PR adding OSC 22 support, and I'm going to continue it.