fix(utils): use correct MIN_TERMINAL_HEIGHT
#4040
Open
+36
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulls out `MIN_TERMINAL_*` constants from `zellij-server` into `zellij-utils` so that they can be used everywhere, without relying on comments to keep magic numbers in sync!
|
I never saw any of the effects of this bug, but I'm sure it'll hurt someone someday... |
|
Yikes, I'll need to figure out how in the world this is breaking a test later... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls out
MIN_TERMINAL_*constants fromzellij-serverintozellij-utilsso that they can be used everywhere, without relying on comments to keep magic numbers in sync!