fix windows build on non-cl compilers

[zeozeozeo]

Unsure how correct the changes in rpmalloc.c are, without the change the clang fails with the error cannot combine with previous 'static' declaration specifier, haven't tested it with MSVC.
The changes in CMakeLists.txt seem to work both on clang and gcc.

[zeozeozeo]

err, doesn't work with msvc

[TheTechsTech]

Unsure how correct the changes in rpmalloc.c are, without the change the clang fails with the error cannot combine with previous 'static' declaration specifier, haven't tested it with MSVC. The changes in CMakeLists.txt seem to work both on clang and gcc.

Not sure what system you on, but clang and gcc already compiles the way CMakeLists.txt is setup. Otherwise, I could not have GitHub Actions produce release binaries for macOS nor Linux.

[zeozeozeo]

macOS nor Linux.

I'm trying to fix it on Windows, since the current CMakeLists assumes that you're running a cl-compatible compiler (MSVC or clang-cl) if you're on Windows.
I'm using clang from https://winlibs.com/, but that issue will probably also happen with LLVM-supplied clang too.

[TheTechsTech]

macOS nor Linux.

I'm trying to fix it on Windows, since the current CMakeLists assumes that you're running a cl-compatible compiler (MSVC or clang-cl) if you're on Windows. I'm using clang from https://winlibs.com/, but that issue will probably also happen with LLVM-supplied clang too.

Cmake really setup to default to native OS host compiler, and my whole setup is an workaround to use tcc for that setup.
But I start off explicitly using whatever is native to the OS/platform to compile tcc.

Your changes is not for native setup, you will have many more issues to train cmake, I find not worth the effort.

Also, rpmalloc.c already compiles with clang on macOS without issue see direct tests, https://github.com/zelang-dev/rpmalloc/actions/runs/11645047833 and https://github.com/zelang-dev/rpmalloc/actions/runs/11060756902

[zeozeozeo]

Cmake really setup to default to native OS host compiler

I'm on Windows and I have $CC set to clang, meaning I have to go out of my way to install/compile with MSVC just to compile tcc, not very convenient :/
but i understand if this is out of the scope of this project, if so this may be closed.

[TheTechsTech]

Yes, that is what I mean, cmake really want you to use native OS compiler, doesn't matter what $CC is, unless using cross compiler. I tried that too.

I build locally on Windows too, then test under WSL2.
I will also test on MacBook Pro, Big Sur, if GitHub Actions show macOS error.