Skip to content

Fix redirects (again) #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025

Conversation

evantypanski
Copy link
Contributor

It turns out #316 was probably worthwhile - but we have too many redirects! It's apparently capped at 100 now, but we have over 600.

So I just moved the quickstart and whatnot back out to the top level directory. There's one redirect change for the cross-compiling section. That one will have to be manually found and changed, I think. I manually changed it.

@evantypanski evantypanski force-pushed the topic/etyp/undo-need-for-redirects-quickstart branch from 2d4d21d to 28819bb Compare May 22, 2025 13:42
@evantypanski evantypanski requested a review from bbannier May 22, 2025 13:43
@evantypanski
Copy link
Contributor Author

@bbannier does this seem proper, after looking at redirects too?

Copy link
Member

@bbannier bbannier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

FTR, I rebased these changes on top of c1a60d0 and looked for stray changes which didn't get reverted.

@evantypanski evantypanski requested a review from bbannier May 22, 2025 14:15
Copy link
Member

@bbannier bbannier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixup commit, much easier to review 😅

🚀

We are way over the RTD limit for redirects so the redirects cannot work
anymore. In order to not break links, this undoes the organization
changes done with the new quickstart in da1a0e0
@evantypanski evantypanski force-pushed the topic/etyp/undo-need-for-redirects-quickstart branch from 195e468 to 1bca3c1 Compare May 22, 2025 14:25
@evantypanski evantypanski merged commit c703c66 into master May 22, 2025
11 checks passed
@evantypanski evantypanski deleted the topic/etyp/undo-need-for-redirects-quickstart branch May 22, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants