Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In some projects we found the lazy worker to be problematic and prefer to implement the lazyness in the application code.
There was also a reconnection bug where the rosys-detector module tries to reconnect while the detector still thinks the connection is established. Problem occured when
auto_disconnect
is False and the detector container is stopped and restarted while the rosys container keeps running. This seems to be solved by explicitly calling disconnect before reconnecting.Implementation