Ensure proper cleanup and error handling in test fixtures #5287
+39
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If an exception happens inside the fixture setup, the fixture was not reset correctly leading to failed tests.
Implementation
screen
anduser
fixtures to usetry...finally
for resource cleanup, ensuring environment variables are reset and servers are stopped even if an error occurs.test_main_file_marker.py
(which failed before)This change enhances the reliability of the testing framework by ensuring that resources are properly managed and that errors are logged appropriately.
Progress