Skip to content

Conversation

evnchn
Copy link
Collaborator

@evnchn evnchn commented Oct 13, 2025

Motivation

Fix #5264, where the margin is inconsistent when language=''

Implementation

  • Changed the selector from .nicegui-markdown .codehilite pre to .nicegui-markdown pre and updated the margin to 0.5rem 0.5rem to provide both horizontal and vertical margin to both codehilite and non-codehilite code blocks.
  • Removed unnecessary padding from .nicegui-code .codehilite.

Visual difference

Before:

image

After:

image

Progress

  • I chose a meaningful title that completes the sentence: "If applied, this PR will..."
  • The implementation is complete.
  • Pytests have been added (or are not necessary).
  • Documentation has been added (or is not necessary).

@evnchn evnchn added the bug Type/scope: A problem that needs fixing label Oct 13, 2025
@rodja rodja requested a review from falkoschindler October 13, 2025 03:14
@falkoschindler falkoschindler added the review Status: PR is open and needs review label Oct 15, 2025
@falkoschindler falkoschindler added this to the 3.1 milestone Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Type/scope: A problem that needs fixing review Status: PR is open and needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing spacing in ui.code without language specification

2 participants