Modernize our vbuild
to use ESM import rather than inlining the JS
#5257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The mastermind is and always has been @xaptronic (see #4673), but things went stale and that PR becomes harder and harder to merge as time marches onwards.
The potential advantages are at #4673 (comment) but you should read above the first
---
because the rest are about the refactoring ofvbuild
and no AI can beat @falkoschindler (look at #5255)Implementation
The logic is 3:
create_vue_component
betweenself.script
andparser.script
(check Allow nicegui SFC script section to use ESM / import syntax #4673 (comment))js_imports
instead ofvue_scripts
vue_components
from_get_component
Progress