Let tests fail if there is a javascript error NOW

nicegui/elements/echart/echart.js

@@ -94,7 +94,9 @@ export default {
         return;
       }
       convertDynamicProperties(this.options, true);
-      this.chart.setOption(this.options, { notMerge: this.chart.options?.series.length != this.options.series.length });
+      this.chart.setOption(this.options, {
+        notMerge: this.chart.options?.series?.length != this.options.series?.length,
+      });
     },
     run_chart_method(name, ...args) {
       if (name.startsWith(":")) {

nicegui/testing/screen.py

@@ -40,6 +40,7 @@ def __init__(self, selenium: webdriver.Chrome, caplog: pytest.LogCaptureFixture,
         self.connected = threading.Event()
         app.on_connect(self.connected.set)
         self.url = f'http://localhost:{self.PORT}'
+        self.allow_js_errors: bool = False
 
     def start_server(self) -> None:
         """Start the webserver in a separate thread."""

nicegui/testing/screen_plugin.py

@@ -83,3 +83,10 @@ def screen(nicegui_reset_globals,  # noqa: F811, pylint: disable=unused-argument
         shutil.rmtree(DOWNLOAD_DIR)
     if logs:
         pytest.fail('There were unexpected ERROR logs.', pytrace=False)
+
+    if screen_.is_open:
+        browser_logs = screen_.selenium.get_log('browser')
+        js_errors = [e for e in browser_logs if str(e.get('level', '')).upper() in (
+            'SEVERE', 'ERROR')]
+        if js_errors and not screen_.allow_js_errors:
+            pytest.fail(f'JavaScript console errors:\n{js_errors}', pytrace=False)

tests/test_chat_message.py

@@ -22,6 +22,7 @@ def page():
         with pytest.raises(ValueError):
             ui.chat_message('80€', text_html=True)
 
+    screen.allow_js_errors = True  # Reason: accessing /x will trigger JS errors
     screen.open('/')
     screen.should_contain('10€')
     screen.should_contain('20€')

tests/test_element.py

@@ -362,7 +362,7 @@ class MyButton(ui.button):
 def test_invalid_tags(screen: Screen):
     @ui.page('/')
     def page():
-        good_tags = ['div', 'div-1', 'DIV', 'däv', 'div_x', '🙂']
+        good_tags = ['div', 'div-1', 'DIV', 'däv', 'div_x']  # '🙂' is not valid, as it turns out
         bad_tags = ['<div>', 'hi hi', 'hi/ho', 'foo$bar']
         for tag in good_tags:
             ui.element(tag)

tests/test_endpoint_docs.py

@@ -15,14 +15,23 @@ def get_openapi_paths() -> set[str]:
 
 
 def test_endpoint_documentation_default(screen: Screen):
+    @ui.page('/')
+    def page():
+        ui.markdown('Hey!')
+
     screen.open('/')
     assert get_openapi_paths() == set()
 
 
 def test_endpoint_documentation_page_only(screen: Screen):
     screen.ui_run_kwargs['endpoint_documentation'] = 'page'
+
+    @ui.page('/')
+    def page():
+        ui.markdown('Hey!')
+
     screen.open('/')
-    assert get_openapi_paths() == set()
+    assert get_openapi_paths() == {'/'}
 
 
 def test_endpoint_documentation_internal_only(screen: Screen):

tests/test_html.py

@@ -31,6 +31,7 @@ def page():
         ui.html('<img src=x onerror=Quasar.Notify.create({message:"C"})>', sanitize=lambda x: x.replace('C', 'C!'))
         ui.html('<img src=x onerror=Quasar.Notify.create({message:"D"})>', sanitize=Sanitizer().sanitize)
 
+    screen.allow_js_errors = True  # Reason: accessing /x will trigger JS errors
     screen.open('/')
     screen.should_contain('A')
     screen.should_contain('B')

tests/test_page.py

@@ -137,6 +137,7 @@ def test_exception(screen: Screen):
     def page():
         raise RuntimeError('some exception')
 
+    screen.allow_js_errors = True  # Reason: accessing / will trigger JS errors
     screen.open('/')
     screen.should_contain('500')
     screen.should_contain('Server error')
@@ -310,5 +311,6 @@ async def page():
         await asyncio.sleep(1)
         ui.label('all done')
 
+    screen.allow_js_errors = True  # Reason: / will error out due to intentional delay
     screen.open('/')
     screen.assert_py_logger('WARNING', re.compile('Response for / not ready after 0.5 seconds'))

tests/test_storage.py

@@ -290,6 +290,7 @@ def page():
         ui.label(app.storage.user.get('message', 'no message'))
 
     core.app.user_middleware.clear()  # remove the session middlewares added by prepare_simulation by default
+    screen.allow_js_errors = True  # Reason: accessing / will trigger JS errors (it is missing)
     screen.open('/')
     screen.assert_py_logger('ERROR', 'app.storage.user needs a storage_secret passed in ui.run()')