ui.log
scroll-to-bottom working in ui.tab_panel
#5220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #5118, where we find #5112 (or, actually, the reimplementation of it in 3.0, since we do
q-scroll-area
forui.log
) does not work insideui.tab
.Implementation
I did 2 things:
document.body.contains(this.$refs.qRef.$el)
(aka only when body contains the element, which is false when theui.log
hidden due to inactive inui.tab_panel
scrollTop + clientHeight >= scrollHeight
approach for checking current scroll but we do it onthis.$refs.qRef.$el.childNodes[0]
this time around.getScroll().verticalPercentage
isn't accurate whileui.tab_panel
under animation effect.Progress