Enable setting session cookie attributes from ui.run() #5213
+51
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using
app.storage.user
it creates a session cookie with permissions that disallow cross-origin usage. While this is a good secure default, there's currently no way to override it when needed, e.g. if you want your NiceGUI site to be embeddable as an iframe from another domain. See discussion #4252.Implementation
A new argument is added to
ui.run()
which allows passing keyword arguments that will be forwarded to the SessionMiddleware that is used to create the session cookie.Progress