Skip to content

Conversation

evnchn
Copy link
Collaborator

@evnchn evnchn commented Oct 4, 2025

Motivation

I just checked and we can install chromium and chromium-driver on ARM64, covering a major use case of developing on Apple Silicon Macs

image

I can't trace back which release it was supported, though.

So we can revert #3328 and improve devcontainer performance.

For those who need AMD64 they can specify it themselves?

Implementation

Revert #3328, drop --platform=linux/amd64

Progress

  • I chose a meaningful title that completes the sentence: "If applied, this PR will..."
  • The implementation is complete.
  • Pytests are not necessary.
  • Documentation is not necessary.

@evnchn evnchn added the infrastructure Type/scope: GitHub Actions and IDE label Oct 4, 2025
@falkoschindler falkoschindler requested a review from rodja October 4, 2025 14:34
@falkoschindler falkoschindler added this to the 3.1 milestone Oct 4, 2025
@evnchn
Copy link
Collaborator Author

evnchn commented Oct 6, 2025

I'm still on the ARM64 devcontainer, by the way.

@evnchn
Copy link
Collaborator Author

evnchn commented Oct 6, 2025

Tests cannot run??

🤡

image

I don't have that much experience. Let's make this draft until someone can look at this and make the tests pass, so that we don't accidentally merge this and mess up the devcontainer for everybody.

@evnchn evnchn marked this pull request as draft October 6, 2025 17:21
@evnchn
Copy link
Collaborator Author

evnchn commented Oct 9, 2025

Don't ask me why but with e2c6ba9 it works

Not all tests pass though, some fail, but I don't know why. The tests which do pass though, they are very fast.

@evnchn
Copy link
Collaborator Author

evnchn commented Oct 15, 2025

I just realized that actually for Polars it will complain if you use AMD64 devcontainer on Apple Silicon

https://github.com/pola-rs/polars/blob/afdbf3056d1228cf493901e45f536b0905cec8ea/py-polars/src/polars/_cpu_check.py#L250-L262

So for Apple Silicon Macs, this PR is more important than what it seems.

@evnchn evnchn marked this pull request as ready for review October 15, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Type/scope: GitHub Actions and IDE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants