Skip to content

Conversation

evnchn
Copy link
Collaborator

@evnchn evnchn commented Sep 22, 2025

Motivation

Further develop on #5161. For PyPy to be first-class (or second-class) citizen of NiceGUI it has to, at the very least, run our test suite

Implementation

  • Add PyPy into the pipeline.
  • Expand the timeout to 120 minutes for now
  • Drop LangChain, OpenCV, numpy (and other things which use numpy) from test
  • Drop reference counter related test
  • Loosen timing for event tests

Progress

  • I chose a meaningful title that completes the sentence: "If applied, this PR will..."
  • The implementation is complete.
  • Pytests are not necessary.
  • Documentation is not necessary.

@evnchn evnchn marked this pull request as draft September 22, 2025 16:06
@evnchn
Copy link
Collaborator Author

evnchn commented Sep 22, 2025

Missing pydantic core. Huh. But pydantic was installed, no?

https://github.com/evnchn/nicegui/actions/runs/17921019299

@evnchn
Copy link
Collaborator Author

evnchn commented Sep 22, 2025

pydantic-core is a rust component. Until we figure out why it fails in the pipeline (it doesn't fail installing on my machine) we can use Pydantic V1 for now: https://github.com/fastapi/fastapi/blob/master/pyproject.toml#L31

@evnchn evnchn marked this pull request as ready for review September 23, 2025 11:46
@evnchn evnchn mentioned this pull request Sep 23, 2025
4 tasks
@evnchn evnchn added the feature Type/scope: New feature or enhancement label Sep 23, 2025
@evnchn evnchn changed the title Pypy in test pipeline PyPy support with test pipeline Sep 23, 2025
@evnchn evnchn mentioned this pull request Sep 23, 2025
2 tasks
@falkoschindler falkoschindler added this to the 3.x milestone Sep 23, 2025
@falkoschindler falkoschindler added the review Status: PR is open and needs review label Sep 23, 2025
@evnchn evnchn force-pushed the pypy-in-test-pipeline branch from c32aa7f to 83a3ba7 Compare October 9, 2025 11:18
@evnchn evnchn force-pushed the pypy-in-test-pipeline branch from 83a3ba7 to 210ebdf Compare October 9, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Type/scope: New feature or enhancement review Status: PR is open and needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants