Skip to content

Eliminates B006 warnings from root-cause #4826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Eliminates B006 warnings from root-cause #4826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions nicegui/element.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,18 @@ def __init__(self, tag: Optional[str] = None, *, _client: Optional[Client] = Non

def __init_subclass__(cls, *,
component: Union[str, Path, None] = None,
dependencies: List[Union[str, Path]] = [], # noqa: B006
libraries: List[Union[str, Path]] = [], # noqa: B006 # DEPRECATED
exposed_libraries: List[Union[str, Path]] = [], # noqa: B006 # DEPRECATED
extra_libraries: List[Union[str, Path]] = [], # noqa: B006 # DEPRECATED
dependencies: Optional[List[Union[str, Path]]] = None,
libraries: Optional[List[Union[str, Path]]] = None, # DEPRECATED
exposed_libraries: Optional[List[Union[str, Path]]] = None, # DEPRECATED
extra_libraries: Optional[List[Union[str, Path]]] = None, # DEPRECATED
default_classes: Optional[str] = None,
default_style: Optional[str] = None,
default_props: Optional[str] = None,
) -> None:
dependencies = dependencies or []
libraries = libraries or []
exposed_libraries = exposed_libraries or []
extra_libraries = extra_libraries or []
super().__init_subclass__()
base = Path(inspect.getfile(cls)).parent

Expand Down
20 changes: 15 additions & 5 deletions nicegui/elements/aggrid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class AgGrid(Element,

def __init__(self,
options: Dict, *,
html_columns: List[int] = [], # noqa: B006
html_columns: Optional[List[int]] = None,
theme: Optional[str] = 'balham',
auto_size_columns: bool = True,
) -> None:
Expand All @@ -40,6 +40,8 @@ def __init__(self,
:param theme: AG Grid theme (default: "balham")
:param auto_size_columns: whether to automatically resize columns to fit the grid width (default: ``True``)
"""
if html_columns is None:
html_columns = []
super().__init__()
self._props['options'] = options
self._props['html_columns'] = html_columns[:]
Expand All @@ -51,10 +53,10 @@ def __init__(self,
@classmethod
def from_pandas(cls,
df: 'pd.DataFrame', *,
html_columns: List[int] = [], # noqa: B006
html_columns: Optional[List[int]] = None,
theme: Optional[str] = 'balham',
auto_size_columns: bool = True,
options: Dict = {}) -> Self: # noqa: B006
options: Optional[Dict] = None) -> Self:
"""Create an AG Grid from a Pandas DataFrame.

Note:
Expand All @@ -70,6 +72,10 @@ def from_pandas(cls,
:param options: dictionary of additional AG Grid options
:return: AG Grid element
"""
if html_columns is None:
html_columns = []
if options is None:
options = {}
import pandas as pd # pylint: disable=import-outside-toplevel

def is_special_dtype(dtype):
Expand Down Expand Up @@ -97,10 +103,10 @@ def is_special_dtype(dtype):
@classmethod
def from_polars(cls,
df: 'pl.DataFrame', *,
html_columns: List[int] = [], # noqa: B006
html_columns: Optional[List[int]] = None,
theme: Optional[str] = 'balham',
auto_size_columns: bool = True,
options: Dict = {}) -> Self: # noqa: B006
options: Optional[Dict] = None) -> Self:
"""Create an AG Grid from a Polars DataFrame.

If the DataFrame contains non-UTF-8 datatypes, they will be converted to strings.
Expand All @@ -115,6 +121,10 @@ def from_polars(cls,
:param options: dictionary of additional AG Grid options
:return: AG Grid element
"""
if html_columns is None:
html_columns = []
if options is None:
options = {}
return cls({
'columnDefs': [{'field': str(col)} for col in df.columns],
'rowData': df.to_dicts(),
Expand Down
4 changes: 3 additions & 1 deletion nicegui/elements/interactive_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def __init__(self,
content: str = '',
size: Optional[Tuple[float, float]] = None,
on_mouse: Optional[Handler[MouseEventArguments]] = None,
events: List[str] = ['click'], # noqa: B006
events: Optional[List[str]] = None,
cross: Union[bool, str] = False,
) -> None:
"""Interactive Image
Expand Down Expand Up @@ -57,6 +57,8 @@ def __init__(self,
:param events: list of JavaScript events to subscribe to (default: `['click']`)
:param cross: whether to show crosshairs or a color string (default: `False`)
"""
if events is None:
events = ['click']
super().__init__(source=source, content=content)
self._props['events'] = events[:]
self._props['cross'] = cross
Expand Down
5 changes: 3 additions & 2 deletions nicegui/elements/keyboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ def __init__(self,
on_key: Optional[Handler[KeyEventArguments]] = None, *,
active: bool = True,
repeating: bool = True,
ignore: List[Literal['input', 'select', 'button', 'textarea']] =
['input', 'select', 'button', 'textarea'], # noqa: B006
ignore: Optional[List[Literal['input', 'select', 'button', 'textarea']]] = None,
) -> None:
"""Keyboard

Expand Down Expand Up @@ -60,6 +59,8 @@ def __init__(self,
:param repeating: boolean flag indicating whether held keys should be sent repeatedly (default: ``True``)
:param ignore: ignore keys when one of these element types is focussed (default: ``['input', 'select', 'button', 'textarea']``)
"""
if ignore is None:
ignore = ['input', 'select', 'button', 'textarea']
super().__init__()
self._key_handlers = [on_key] if on_key else []
self.active = active
Expand Down
4 changes: 3 additions & 1 deletion nicegui/elements/leaflet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def __init__(self,
center: Tuple[float, float] = (0.0, 0.0),
zoom: int = 13,
*,
options: Dict = {}, # noqa: B006
options: Optional[Dict] = None,
draw_control: Union[bool, Dict] = False,
hide_drawn_items: bool = False,
additional_resources: Optional[List[str]] = None,
Expand All @@ -43,6 +43,8 @@ def __init__(self,
:param hide_drawn_items: whether to hide drawn items on the map (default: False, *added in version 2.0.0*)
:param additional_resources: additional resources like CSS or JS files to load (default: None, *added in version 2.11.0*)
"""
if options is None:
options = {}
super().__init__()
self.add_resource(Path(__file__).parent / 'lib' / 'leaflet')

Expand Down
6 changes: 4 additions & 2 deletions nicegui/elements/markdown.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import os
from functools import lru_cache
from typing import List
from typing import List, Optional

import markdown2
from fastapi.responses import PlainTextResponse
Expand All @@ -13,7 +13,7 @@ class Markdown(ContentElement, component='markdown.js', default_classes='nicegui

def __init__(self,
content: str = '', *,
extras: List[str] = ['fenced-code-blocks', 'tables'], # noqa: B006
extras: Optional[List[str]] = None,
Copy link

Copilot AI Jun 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring still describes the default extras as ['fenced-code-blocks', 'tables']; consider updating it to note that passing None results in those defaults being applied internally.

Copilot uses AI. Check for mistakes.

) -> None:
"""Markdown Element

Expand All @@ -22,6 +22,8 @@ def __init__(self,
:param content: the Markdown content to be displayed
:param extras: list of `markdown2 extensions <https://github.com/trentm/python-markdown2/wiki/Extras#implemented-extras>`_ (default: `['fenced-code-blocks', 'tables']`)
"""
if extras is None:
extras = ['fenced-code-blocks', 'tables']
self.extras = extras[:]
super().__init__(content=content)
if 'mermaid' in extras:
Expand Down
4 changes: 3 additions & 1 deletion nicegui/elements/scene.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def __init__(self,
grid: Union[bool, Tuple[int, int]] = True,
camera: Optional[SceneCamera] = None,
on_click: Optional[Handler[SceneClickEventArguments]] = None,
click_events: List[str] = ['click', 'dblclick'], # noqa: B006
click_events: Optional[List[str]] = None,
on_drag_start: Optional[Handler[SceneDragEventArguments]] = None,
on_drag_end: Optional[Handler[SceneDragEventArguments]] = None,
drag_constraints: str = '',
Expand All @@ -101,6 +101,8 @@ def __init__(self,
:param drag_constraints: comma-separated JavaScript expression for constraining positions of dragged objects (e.g. ``'x = 0, z = y / 2'``)
:param background_color: background color of the scene (default: "#eee")
"""
if click_events is None:
click_events = ['click', 'dblclick']
super().__init__()
self._props['width'] = width
self._props['height'] = height
Expand Down