Provide pytest-plugin that registers a 'gpu' marker. #3258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/zarr-developers/zarr-python/pull/3191/files#diff-a801b931f5dd8cd7df666e3f9936ff520669296303d3a3e469514443211885bdR43 changed `zarr.testing.utils` to use a top-level `pytest.mark.gpu`. Many projects, including zarr, run with `--strict-markers` which causes pytest to raise an error if the test you're running uses an unregistered marker. This didn't cause any issues for zarr, since we already registered the `gpu` marker. However, downstream projects are intended to run the `StoreTests`, which exposes them to this marker. To ensure they get it when installing zarr, we'll include an entrypoint with pytest, so that pytest calls our code to register this marker when these tests run.
dcherian
approved these changes
Jul 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3258 +/- ##
===========================================
- Coverage 94.62% 59.59% -35.04%
===========================================
Files 78 78
Lines 8696 8696
===========================================
- Hits 8229 5182 -3047
- Misses 467 3514 +3047 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/zarr-developers/zarr-python/pull/3191/files#diff-a801b931f5dd8cd7df666e3f9936ff520669296303d3a3e469514443211885bdR43 changed
zarr.testing.utilsto use a top-levelpytest.mark.gpu. Many projects, including zarr, run with--strict-markerswhich causes pytest to raise an error if the test you're running uses an unregistered marker. This didn't cause any issues for zarr, since we already registered thegpumarker.However, downstream projects are intended to run the
StoreTests, which exposes them to this marker. To ensure they get it when installing zarr, we'll include an entrypoint with pytest, so that pytest calls our code to register this marker when these tests run.