Skip to content

Write chunks with negative zero values and a zero fill value #3216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/3144.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Ensure that -0.0 is not considered equal to 0.0 when checking if all the values in a chunk are equal to an array's fill value.```
6 changes: 6 additions & 0 deletions src/zarr/core/buffer/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,12 @@ def all_equal(self, other: Any, equal_nan: bool = True) -> bool:
if other is None:
# Handle None fill_value for Zarr V2
return False
if other == 0.0 and self._data.dtype.kind not in ("U", "S", "T", "O", "V"):
# Handle positive and negative zero
if np.any(self._data): # Check for any truthy value
return False
# Check signs:
return np.array_equiv(np.signbit(self._data), np.signbit(other))
# use array_equal to obtain equal_nan=True functionality
# Since fill-value is a scalar, isn't there a faster path than allocating a new array for fill value
# every single time we have to write data?
Expand Down
24 changes: 24 additions & 0 deletions tests/test_array.py
Original file line number Diff line number Diff line change
Expand Up @@ -904,6 +904,30 @@ def test_write_empty_chunks_behavior(
assert arr.nchunks_initialized == arr.nchunks


@pytest.mark.parametrize("store", ["memory"], indirect=True)
@pytest.mark.parametrize("fill_value", [0.0, -0.0])
def test_write_empty_chunks_negative_zero(
zarr_format: ZarrFormat, store: MemoryStore, fill_value: float
) -> None:
# regression test for https://github.com/zarr-developers/zarr-python/issues/3144

arr = zarr.create_array(
store=store,
shape=(2,),
zarr_format=zarr_format,
dtype="f4",
fill_value=fill_value,
chunks=(1,),
config={"write_empty_chunks": False},
)

assert arr.nchunks_initialized == 0

# initialize the with the negated fill value (-0.0 for +0.0, +0.0 for -0.0)
arr[:] = -fill_value
assert arr.nchunks_initialized == arr.nchunks


@pytest.mark.parametrize(
("fill_value", "expected"),
[
Expand Down
Loading