Skip to content

Make consolidate_metadata for DirectoryStore following symlinks #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ctamluu
Copy link

@ctamluu ctamluu commented Aug 2, 2024

No description provided.

@joshmoore
Copy link
Member

joshmoore commented Aug 2, 2024

Thanks, @ctamluu. I've triggered the workflows. Can you perhaps update the description with some background information on what you are trying to achieve? Is there an example fileset somewhere that we could take a look at?

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (0855bd6) to head (4464b37).
Report is 56 commits behind head on support/v2.

Additional details and impacted files
@@              Coverage Diff               @@
##           support/v2    #2063      +/-   ##
==============================================
- Coverage       99.98%   99.98%   -0.01%     
==============================================
  Files              38       38              
  Lines           14703    14700       -3     
==============================================
- Hits            14701    14698       -3     
  Misses              2        2              
Files with missing lines Coverage Δ
zarr/storage.py 100.00% <100.00%> (ø)
zarr/tests/test_storage.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhamman jhamman added the V2 Affects the v2 branch label Sep 13, 2024
@jhamman jhamman changed the base branch from main to support/2.x October 11, 2024 23:02
@jhamman
Copy link
Member

jhamman commented Oct 11, 2024

I have changed the base branch of this PR to be support/2.x.

@dstansby
Copy link
Contributor

Thanks for opening this PR and contibuting to zarr-python! Since it's a few months old now, and we don't have some more context around what issue you're trying to solve, I'm going to close this so we can clean up our list of open PRs. Please do feel free to re-submit it with some more information on the issue you're trying to fix.

@dstansby dstansby closed this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 Affects the v2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants